Skip to content

Commit b9e5cc0

Browse files
committed
address review comments
Signed-off-by: Pankaj Walke <[email protected]>
1 parent d9689da commit b9e5cc0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/cloud/converters/eks.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ func NodegroupUpdateconfigFromSDK(ngUpdateConfig *ekstypes.NodegroupUpdateConfig
217217
return converted
218218
}
219219

220-
// AMITypeToSDK is used to CAPA ManagedMachineAMIType to AWS SDK AMIType.
220+
// AMITypeToSDK converts a CAPA ManagedMachineAMIType to AWS SDK AMIType.
221221
func AMITypeToSDK(amiType expinfrav1.ManagedMachineAMIType) ekstypes.AMITypes {
222222
switch amiType {
223223
case expinfrav1.Al2x86_64:

test/e2e/shared/suite.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ func Node1BeforeSuite(e2eCtx *E2EContext) []byte {
157157
ensureSSHKeyPair(e2eCtx.AWSSession, DefaultSSHKeyPairName)
158158
e2eCtx.Environment.BootstrapAccessKey = newUserAccessKey(context.TODO(), e2eCtx.AWSConfig, bootstrapTemplate.Spec.BootstrapUser.UserName)
159159
e2eCtx.BootstrapUserAWSSession = NewAWSSessionWithKey(e2eCtx.Environment.BootstrapAccessKey)
160-
// v2AccessKey can be removed after AWS SDK V2 Migration
160+
//TODO: v2AccessKey can be removed after AWS SDK V2 Migration
161161
v2AccessKey := &iamtypes.AccessKey{
162162
AccessKeyId: e2eCtx.Environment.BootstrapAccessKey.AccessKeyId,
163163
SecretAccessKey: e2eCtx.Environment.BootstrapAccessKey.SecretAccessKey,
@@ -231,7 +231,7 @@ func AllNodesBeforeSuite(e2eCtx *E2EContext, data []byte) {
231231
e2eCtx.Environment.BootstrapClusterProxy = framework.NewClusterProxy("bootstrap", conf.KubeconfigPath, e2eCtx.Environment.Scheme)
232232
e2eCtx.E2EConfig = &conf.E2EConfig
233233
e2eCtx.BootstrapUserAWSSession = NewAWSSessionWithKey(conf.BootstrapAccessKey)
234-
// v2AccessKey can be removed after AWS SDK V2 Migration
234+
//TODO: v2AccessKey can be removed after AWS SDK V2 Migration
235235
v2AccessKey := &iamtypes.AccessKey{
236236
AccessKeyId: e2eCtx.Environment.BootstrapAccessKey.AccessKeyId,
237237
SecretAccessKey: e2eCtx.Environment.BootstrapAccessKey.SecretAccessKey,

0 commit comments

Comments
 (0)