Skip to content

Commit bc1d3b1

Browse files
authored
Merge pull request #4813 from kubernetes-sigs/release_fixes
🐛 fix: changes to release process
2 parents 8b4231d + c06d1ff commit bc1d3b1

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

Makefile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ include $(ROOT_DIR_RELATIVE)/common.mk
2121

2222
# Go
2323
GO_VERSION ?=1.21.5
24-
GO_CONTAINER_IMAGE ?= public.ecr.aws/docker/library/golang:$(GO_VERSION)
24+
GO_CONTAINER_IMAGE ?= golang:$(GO_VERSION)
2525

2626
# Directories.
2727
ARTIFACTS ?= $(REPO_ROOT)/_artifacts
@@ -607,18 +607,17 @@ release-binaries: ## Builds the binaries to publish with a release
607607
RELEASE_BINARY=./cmd/clusterawsadm GOOS=windows GOARCH=arm64 EXT=.exe $(MAKE) release-binary
608608

609609
.PHONY: release-binary
610-
release-binary: $(RELEASE_DIR) versions.mk build-toolchain ## Release binary
610+
release-binary: $(RELEASE_DIR) versions.mk ## Release binary
611611
docker run \
612612
--rm \
613613
-e CGO_ENABLED=0 \
614614
-e GOOS=$(GOOS) \
615615
-e GOARCH=$(GOARCH) \
616-
--mount=source=gocache,target=/go/pkg/mod \
617-
--mount=source=gocache,target=/root/.cache/go-build \
616+
-e GOCACHE=/tmp/ \
617+
--user $$(id -u):$$(id -g) \
618618
-v "$$(pwd):/workspace$(DOCKER_VOL_OPTS)" \
619619
-w /workspace \
620-
$(TOOLCHAIN_IMAGE) \
621-
git config --global --add safe.directory /workspace; \
620+
$(GO_CONTAINER_IMAGE) \
622621
go build -ldflags '$(LDFLAGS) -extldflags "-static"' \
623622
-o $(RELEASE_DIR)/$(notdir $(RELEASE_BINARY))-$(GOOS)-$(GOARCH)$(EXT) $(RELEASE_BINARY)
624623

cloudbuild-nightly.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ timeout: 3000s
33
options:
44
substitution_option: ALLOW_LOOSE
55
steps:
6-
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20220609-2e4c91eb7e'
6+
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240210-29014a6e3a'
77
entrypoint: make
88
env:
99
- DOCKER_CLI_EXPERIMENTAL=enabled

cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ timeout: 3000s
33
options:
44
substitution_option: ALLOW_LOOSE
55
steps:
6-
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20220609-2e4c91eb7e'
6+
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240210-29014a6e3a'
77
entrypoint: make
88
env:
99
- DOCKER_CLI_EXPERIMENTAL=enabled

go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ module sigs.k8s.io/cluster-api-provider-aws/v2
22

33
go 1.21
44

5+
toolchain go1.21.5
6+
57
replace (
68
// kube-openapi should match the version imported by CAPI.
79
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9

hack/tools/go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ module sigs.k8s.io/cluster-api-provider-aws/hack/tools
22

33
go 1.21
44

5+
toolchain go1.21.5
6+
57
// kube-openapi should match the version imported by kustomize.
68
replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f
79

0 commit comments

Comments
 (0)