tmp2

Author: PanSpagetka

controllers/suite_test.go

@@ -27,7 +27,6 @@ import (
 
 	infrav1 "sigs.k8s.io/cluster-api-provider-aws/v2/api/v1beta2"
 	"sigs.k8s.io/cluster-api-provider-aws/v2/test/helpers"
-
 	// +kubebuilder:scaffold:imports
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 	kubeadmv1beta1 "sigs.k8s.io/cluster-api/controlplane/kubeadm/api/v1beta1"

exp/api/v1beta2/rosaroleconfig_types.go

@@ -153,7 +153,7 @@ type ROSARoleConfigList struct {
 
 const (
 	// RosaRoleConfigReadyCondition condition reports on the successful reconciliation of RosaRoleConfig.
-	RosaRoleConfigReadyCondition clusterv1.ConditionType = "RosaRoleConfigReady"
+	RosaRoleConfigReadyCondition = "RosaRoleConfigReady"
 
 	// RosaRoleConfigDeletionFailedReason used to report failures while deleting RosaRoleConfig.
 	RosaRoleConfigDeletionFailedReason = "DeletionFailed"
@@ -163,18 +163,21 @@ const (
 
 	// RosaRoleConfigDeletionStarted used to indicate that the deletion of RosaRoleConfig has started.
 	RosaRoleConfigDeletionStarted = "DeletionStarted"
+
+	// RosaRoleConfigCreatedReason used to indicate that the RosaRoleConfig has been created.
+	RosaRoleConfigCreatedReason = "Created"
 )
 
+// SetConditions sets the conditions of the ROSARoleConfig.
+func (r *ROSARoleConfig) SetConditions(conditions clusterv1.Conditions) {
+	r.Status.Conditions = conditions
+}
+
 // GetConditions returns the observations of the operational state of the RosaNetwork resource.
 func (r *ROSARoleConfig) GetConditions() clusterv1.Conditions {
 	return r.Status.Conditions
 }
 
-// SetConditions sets the underlying service state of the RosaRoleConfig to the predescribed clusterv1.Conditions.
-func (r *ROSARoleConfig) SetConditions(conditions clusterv1.Conditions) {
-	r.Status.Conditions = conditions
-}
-
 func init() {
 	SchemeBuilder.Register(&ROSARoleConfig{}, &ROSARoleConfigList{})
 }

exp/controllers/rosaroleconfig_controller.go

@@ -37,6 +37,7 @@ import (
 	rosalogging "github.com/openshift/rosa/pkg/logging"
 	"github.com/openshift/rosa/pkg/ocm"
 	rosacli "github.com/openshift/rosa/pkg/rosa"
+	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/klog/v2"
@@ -164,7 +165,14 @@ func (r *ROSARoleConfigReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 
 	if r.rosaRolesConfigReady(scope) {
 		conditions.MarkTrue(scope.RosaRoleConfig, expinfrav1.RosaRoleConfigReadyCondition)
-
+		conditions.Set(scope.RosaRoleConfig,
+			&clusterv1.Condition{
+				Type:     expinfrav1.RosaRoleConfigReadyCondition,
+				Status:   corev1.ConditionTrue,
+				Reason:   expinfrav1.RosaRoleConfigCreatedReason,
+				Severity: clusterv1.ConditionSeverityInfo,
+				Message:  "RosaRoleConfig is ready to be used.",
+			})
 	}
 	return ctrl.Result{}, nil
 }