Skip to content

Commit f20c52d

Browse files
authored
Merge pull request #4946 from nrb/fix-4926
🐛 Use release branch when generating changelog
2 parents a64bed0 + 5beec01 commit f20c52d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,10 @@ check-release-tag: ## Check if the release tag is set
503503
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
504504
@if ! [ -z "$$(git status --porcelain)" ]; then echo "Your local git repository contains uncommitted changes, use git clean before proceeding."; exit 1; fi
505505

506+
.PHONY: check-release-branch
507+
check-release-branch: ## Check if the release branch is set
508+
@if [ -z "${RELEASE_BRANCH}" ]; then echo "RELEASE_BRANCH is not set"; exit 1; fi
509+
506510
.PHONY: compiled-manifest
507511
compiled-manifest: $(RELEASE_DIR) $(KUSTOMIZE) ## Compile the manifest files
508512
$(MAKE) image-patch-source-manifest
@@ -563,7 +567,7 @@ list-image: ## List images for RELEASE_TAG
563567
gcloud container images list-tags $(STAGING_REGISTRY)/$(IMAGE) --filter="tags=('$(RELEASE_TAG)')" --format=json
564568

565569
.PHONY: release
566-
release: clean-release check-release-tag $(RELEASE_DIR) $(GORELEASER) ## Builds and push container images using the latest git tag for the commit.
570+
release: clean-release check-release-tag check-release-branch $(RELEASE_DIR) $(GORELEASER) ## Builds and push container images using the latest git tag for the commit.
567571
git checkout "${RELEASE_TAG}"
568572
$(MAKE) release-changelog
569573
CORE_CONTROLLER_IMG=$(PROD_REGISTRY)/$(CORE_IMAGE_NAME) $(MAKE) release-manifests
@@ -595,7 +599,7 @@ release-manifests: ## Release manifest files
595599

596600
.PHONY: release-changelog
597601
release-changelog: $(RELEASE_NOTES) check-release-tag check-previous-release-tag check-github-token $(RELEASE_DIR)
598-
$(RELEASE_NOTES) --debug --org $(GH_ORG_NAME) --repo $(GH_REPO_NAME) --start-sha $(shell git rev-list -n 1 ${PREVIOUS_VERSION}) --end-sha $(shell git rev-list -n 1 ${RELEASE_TAG}) --output $(RELEASE_DIR)/CHANGELOG.md --go-template go-template:$(REPO_ROOT)/hack/changelog.tpl --dependencies=false
602+
$(RELEASE_NOTES) --debug --org $(GH_ORG_NAME) --repo $(GH_REPO_NAME) --start-sha $(shell git rev-list -n 1 ${PREVIOUS_VERSION}) --end-sha $(shell git rev-list -n 1 ${RELEASE_TAG}) --output $(RELEASE_DIR)/CHANGELOG.md --go-template go-template:$(REPO_ROOT)/hack/changelog.tpl --dependencies=false --branch=${RELEASE_BRANCH} --required-author=""
599603

600604
.PHONY: promote-images
601605
promote-images: $(KPROMO) $(YQ)

0 commit comments

Comments
 (0)