-
Notifications
You must be signed in to change notification settings - Fork 621
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
controller-runtime has removed the admission.Defaulter
and admission.Validator
interfaces as of v0.20.0 (kubernetes-sigs/controller-runtime#2877)
cluster-api v1.10 uses a version of controller-runtime that no longer has these present.
Looking through related PR history, CAPI has provided an implementer's guide for transitioning these interfaces out of API packages. https://cluster-api.sigs.k8s.io/developer/providers/getting-started/implement-api-types#registering-apis-in-the-scheme
There's also some prior art in how CAPI itself removed these here: kubernetes-sigs/cluster-api#9045
Metadata
Metadata
Assignees
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.