Skip to content

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

wants to merge 1 commit into from
+1,234 −39

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 26, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #5548 to enable CAPA to allocate a dedicated host. This removes the requirement that a dedicated host exist prior to instance provisioning. A core assumption of this PR is that there is a 1:1 mapping between an instance and the dedicated host on which it runs. Nothing in this implementation precludes scheduling multiple instances to a given dedicated host, but that is not the goal of this initial implementation.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emoji in title
  • adds unit tests

Release note:

Adds support for provisioning an instance on a new dedicated host.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 0cadb9a to 2dd765e Compare August 27, 2025 13:54
@punkwalker
Copy link
Contributor

punkwalker commented Aug 27, 2025 •
edited
Loading

Hi @rvanderp3,
Thank you for picking this up.
I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

punkwalker
punkwalker reviewed Aug 27, 2025
View reviewed changes
@rvanderp3
Copy link
Contributor Author

Hi @rvanderp3, Thank you for picking this up. I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

not at all, I appreciate the early feedback

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 2dd765e to 92e2a20 Compare August 27, 2025 20:31
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

covers #5599

@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

@rvanderp3 thanks! this is looking great. I dropped some early feedback.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from e9dc543 to c46e590 Compare August 28, 2025 20:21
@rvanderp3
Copy link
Contributor Author

/retest-required

1 similar comment
@rvanderp3
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 26f35cf to 840e0ae Compare October 6, 2025 21:07
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 6, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 840e0ae to e19d000 Compare October 8, 2025 13:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025
@vr4manta vr4manta mentioned this pull request Oct 10, 2025
Open
mtulio
mtulio reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for addressing the last feedback. Just a few more questions.

@rvanderp3
Copy link
Contributor Author

/hold

placing hold to work through feedback from @mtulio . thanks Marco!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 4 times, most recently from 68142ef to aba4b40 Compare October 15, 2025 19:05
mtulio
mtulio reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rvanderp3 , thanks for addressing the feedback. Couple of nits, and one question of failed condition.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 3 times, most recently from ddf9b78 to d4f729d Compare October 22, 2025 13:26
mtulio
mtulio reviewed Oct 23, 2025
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, @rvanderp3 ! This looks good to me! 👍🏽

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93a56269d2647669a2b4fec8383b7eae75f2c93b

@mtulio
Copy link
Contributor

mtulio commented Oct 23, 2025 •
edited
Loading

Thanks for addressing the comments, @rvanderp3 ! This looks good to me! 👍🏽

/lgtm

@rvanderp3 nit: you may need to squash the commits :)

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from d4f729d to 5acede4 Compare October 23, 2025 19:15
@rvanderp3
Copy link
Contributor Author

Thanks for addressing the comments, @rvanderp3 ! This looks good to me! 👍🏽
/lgtm

@rvanderp3 nit: you may need to squash the commits :)

good point. done!

@mtulio
Copy link
Contributor

mtulio commented Oct 23, 2025

/lgtm

@rvanderp3
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo Awaiting requested review from damdo

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@faiq faiq Awaiting requested review from faiq

3 more reviewers

@enxebre enxebre enxebre left review comments

@mtulio mtulio mtulio left review comments

@punkwalker punkwalker punkwalker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nrb nrb

@mtulio mtulio

@damdo damdo

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rvanderp3 @k8s-ci-robot @punkwalker @enxebre @damdo @mtulio @nrb