-
Notifications
You must be signed in to change notification settings - Fork 635
🐛 ROSA: Fix rosaNetwork set availabilityZones #5718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.9
Are you sure you want to change the base?
Conversation
Signed-off-by: serngawy <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick main |
@serngawy: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@serngawy We normally merge it on main first and then backport it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(but please fix the target branch as mentioned above)
for i, zone := range rosaNetScope.ROSANetwork.Spec.AvailabilityZones { | ||
cfParams[fmt.Sprintf("AZ%d", i)] = zone | ||
for idx, zone := range rosaNetScope.ROSANetwork.Spec.AvailabilityZones { | ||
cfParams[fmt.Sprintf("AZ%d", (idx+1))] = zone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a breaking change – leaving that to you to decide
LGTM label has been added. Git tree hash: 1698879cda4144b79be4af03b77326ede4f2fa6b
|
Fix issue #5715
What type of PR is this?
bug
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: