Skip to content

Conversation

@chrischdi
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes unused conversion functions in favor of #5739

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from damdo November 14, 2025 09:47
@k8s-ci-robot k8s-ci-robot requested a review from faiq November 14, 2025 09:47
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2025
@chrischdi chrischdi force-pushed the pr-drop-unused-conversion-functions branch from d290f2c to f9f767e Compare November 14, 2025 09:58
@damdo
Copy link
Member

damdo commented Nov 14, 2025

/assign @damdo @nrb @richardcase

@damdo
Copy link
Member

damdo commented Nov 14, 2025

/assign @AndiDog

@AndiDog
Copy link
Contributor

AndiDog commented Nov 14, 2025

/lgtm

Waiting for green build

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b4031ad5f30ad33ad021638c9d53a241fac122e

@richardcase
Copy link
Member

If the CI passes feel free to unhold

/hold

From my side:

/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2025
@damdo
Copy link
Member

damdo commented Nov 14, 2025

Failure is a flake

/test pull-cluster-api-provider-aws-e2e-blocking

@damdo
Copy link
Member

damdo commented Nov 14, 2025

/test pull-cluster-api-provider-aws-e2e-blocking

1 similar comment
@damdo
Copy link
Member

damdo commented Nov 14, 2025

/test pull-cluster-api-provider-aws-e2e-blocking

@damdo
Copy link
Member

damdo commented Nov 14, 2025

Great, everything is green

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 805e912 into kubernetes-sigs:main Nov 14, 2025
19 checks passed
@chrischdi
Copy link
Member Author

/cherry-pick release-2.9

@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #5743

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants