✨ Cache architecture for each instance type in memory to avoid unnecessary AWS API requests #5764
+82
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
size/M
AndiDog
force-pushed
the
cache-instance-type-architecture
branch
from
7f0b7ad to
527b12e
Compare
Contributor
Author
|
/test pull-cluster-api-provider-aws-e2e |
1 similar comment
Contributor
Author
|
/test pull-cluster-api-provider-aws-e2e |
Contributor
Author
|
Probably unrelated, trying again /test pull-cluster-api-provider-aws-e2e |
AndiDog
force-pushed
the
cache-instance-type-architecture
branch
from
527b12e to
58aca0e
Compare
Contributor
Author
|
Trying again after rebasing onto E2E test fixes /test pull-cluster-api-provider-aws-e2e |
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 04536ca75432a3fe9700323d56f4daf07d8806f2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
With the MachinePool Machines feature gate turned on, we now see a lot more reconciliation queueing on large MCs due to reconciling a lot of
AWSMachineobjects. This PR was a low-hanging fruit: theDescribeInstanceTypesAWS request is 100% cacheable.This uses CAPI's caching helper and uses a very long caching duration as I don't expect the instance type to architecture mapping to change within AWS.
Confirmed working in our fork already (giantswarm#638).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):n/a
Special notes for your reviewer:
Checklist:
Release note: