Skip to content

Commit 1aa08d0

Browse files
committed
Fix issue with MANAGER_IMAGE being overwritten in conformance tests
1 parent cee81e3 commit 1aa08d0

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

conformance.mk

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ CONFORMANCE_E2E_ARGS += $(E2E_ARGS)
1111

1212
.PHONY: test-conformance
1313
test-conformance: ## Run conformance test on workload cluster.
14+
ifeq ($(MANAGER_IMAGE),)
1415
$(MAKE) test-e2e-skip-push GINKGO_FOCUS="Conformance" E2E_ARGS='$(CONFORMANCE_E2E_ARGS)' CONFORMANCE_FLAVOR='$(CONFORMANCE_FLAVOR)'
16+
else ## If MANAGER_IMAGE is set, use it for the conformance test (test-e2e-skip-push overwrites it).
17+
$(MAKE) test-e2e-custom-image GINKGO_FOCUS="Conformance" E2E_ARGS='$(CONFORMANCE_E2E_ARGS)' CONFORMANCE_FLAVOR='$(CONFORMANCE_FLAVOR)'
18+
endif
1519

1620
test-conformance-fast: ## Run conformance test on workload cluster using a subset of the conformance suite in parallel.
1721
$(MAKE) test-conformance CONFORMANCE_E2E_ARGS="-kubetest.config-file=$(KUBETEST_FAST_CONF_PATH) -kubetest.ginkgo-nodes=5 $(E2E_ARGS)"

0 commit comments

Comments
 (0)