Skip to content

Commit 3203466

Browse files
authored
Merge pull request #2698 from willie-yao/fix-extension-test
Change vm extension test to use resource group name correctly
2 parents 5898fba + e3a3e9e commit 3203466

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

test/e2e/azure_vmextensions.go

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,16 @@ package e2e
2121

2222
import (
2323
"context"
24+
"strings"
2425

2526
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2021-11-01/compute"
27+
autorest "github.com/Azure/go-autorest/autorest/azure"
2628
"github.com/Azure/go-autorest/autorest/azure/auth"
2729
. "github.com/onsi/ginkgo"
2830
. "github.com/onsi/gomega"
2931
corev1 "k8s.io/api/core/v1"
3032
infrav1 "sigs.k8s.io/cluster-api-provider-azure/api/v1beta1"
33+
"sigs.k8s.io/cluster-api-provider-azure/azure"
3134
infrav1exp "sigs.k8s.io/cluster-api-provider-azure/exp/api/v1beta1"
3235
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
3336
"sigs.k8s.io/cluster-api/test/framework"
@@ -93,12 +96,17 @@ func AzureVMExtensionsSpec(ctx context.Context, inputGetter func() AzureVMExtens
9396
vmExtensionsClient := compute.NewVirtualMachineExtensionsClient(subscriptionID)
9497
vmExtensionsClient.Authorizer = auth
9598

96-
vmListResults, err := vmClient.List(ctx, input.ClusterName, "")
99+
// get the resource group name
100+
resourceID := strings.TrimPrefix(*machineList.Items[0].Spec.ProviderID, azure.ProviderIDPrefix)
101+
resource, err := autorest.ParseResourceID(resourceID)
102+
Expect(err).NotTo(HaveOccurred())
103+
104+
vmListResults, err := vmClient.List(ctx, resource.ResourceGroup, "")
97105
Expect(err).NotTo(HaveOccurred())
98106

99107
By("Verifying specified VM extensions are created on Azure")
100108
for _, machine := range vmListResults.Values() {
101-
vmExtensionListResult, err := vmExtensionsClient.List(ctx, input.ClusterName, *machine.Name, "")
109+
vmExtensionListResult, err := vmExtensionsClient.List(ctx, resource.ResourceGroup, *machine.Name, "")
102110
Expect(err).NotTo(HaveOccurred())
103111
vmExtensionList := *vmExtensionListResult.Value
104112
var vmExtensionNames []string
@@ -136,12 +144,17 @@ func AzureVMExtensionsSpec(ctx context.Context, inputGetter func() AzureVMExtens
136144
vmssExtensionsClient := compute.NewVirtualMachineScaleSetExtensionsClient(subscriptionID)
137145
vmssExtensionsClient.Authorizer = auth
138146

139-
vmssListResults, err := vmssClient.List(ctx, input.ClusterName)
147+
// get the resource group name
148+
resourceID := strings.TrimPrefix(machinePoolList.Items[0].Spec.ProviderID, azure.ProviderIDPrefix)
149+
resource, err := autorest.ParseResourceID(resourceID)
150+
Expect(err).NotTo(HaveOccurred())
151+
152+
vmssListResults, err := vmssClient.List(ctx, resource.ResourceGroup)
140153
Expect(err).NotTo(HaveOccurred())
141154

142155
By("Verifying VMSS extensions are created on Azure")
143156
for _, machinePool := range vmssListResults.Values() {
144-
vmssExtensionListResult, err := vmssExtensionsClient.List(ctx, input.ClusterName, *machinePool.Name)
157+
vmssExtensionListResult, err := vmssExtensionsClient.List(ctx, resource.ResourceGroup, *machinePool.Name)
145158
Expect(err).NotTo(HaveOccurred())
146159
vmssExtensionList := vmssExtensionListResult.Values()
147160
var vmssExtensionNames []string

0 commit comments

Comments
 (0)