refactor(golangci-lint): refactor ci errors

Author: viniciussaturnino

api/v1beta1/azurecluster_webhook_test.go

@@ -32,7 +32,7 @@ func TestAzureCluster_ValidateCreate(t *testing.T) {
 		wantErr bool
 	}{
 		{
-			name: "azurecluster with pre-existing vnet - valid spec",
+			name:    "azurecluster with pre-existing vnet - valid spec",
 			cluster: createValidCluster(),
 			wantErr: false,
 		},
@@ -137,7 +137,7 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name: "azurecluster with no control plane endpoint - valid spec",
+			name:       "azurecluster with no control plane endpoint - valid spec",
 			oldCluster: createValidCluster(),
 			cluster: func() *AzureCluster {
 				cluster := createValidCluster()
@@ -150,10 +150,10 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: false,
 		},
 		{
-			name: "azurecluster with pre-existing vnet - valid spec",
+			name:       "azurecluster with pre-existing vnet - valid spec",
 			oldCluster: createValidCluster(),
-			cluster: createValidCluster(),
-			wantErr: false,
+			cluster:    createValidCluster(),
+			wantErr:    false,
 		},
 		{
 			name: "azurecluster without pre-existing vnet - valid spec",
@@ -170,7 +170,7 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: false,
 		},
 		{
-			name: "azurecluster with pre-existing vnet - lack control plane subnet",
+			name:       "azurecluster with pre-existing vnet - lack control plane subnet",
 			oldCluster: createValidCluster(),
 			cluster: func() *AzureCluster {
 				cluster := createValidCluster()
@@ -180,7 +180,7 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name: "azurecluster with pre-existing vnet - lack node subnet",
+			name:       "azurecluster with pre-existing vnet - lack node subnet",
 			oldCluster: createValidCluster(),
 			cluster: func() *AzureCluster {
 				cluster := createValidCluster()
@@ -190,7 +190,7 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name: "azurecluster with pre-existing vnet - invalid resourcegroup name",
+			name:       "azurecluster with pre-existing vnet - invalid resourcegroup name",
 			oldCluster: createValidCluster(),
 			cluster: func() *AzureCluster {
 				cluster := createValidCluster()
@@ -200,7 +200,7 @@ func TestAzureCluster_ValidateUpdate(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name: "azurecluster with pre-existing vnet - invalid subnet name",
+			name:       "azurecluster with pre-existing vnet - invalid subnet name",
 			oldCluster: createValidCluster(),
 			cluster: func() *AzureCluster {
 				cluster := createValidCluster()

config/crd/bases/infrastructure.cluster.x-k8s.io_azureclusters.yaml

@@ -175,7 +175,7 @@ spec:
                       properties:
                         cidrBlock:
                           description: 'CidrBlock is the CIDR block to be used when
-                            the provider creates a managed Vnet. DEPRECATED: Use CIDRBlocks
+                            the provider creates a managed Vnet. Deprecated: Use CIDRBlocks
                             instead'
                           type: string
                         cidrBlocks:
@@ -287,7 +287,7 @@ spec:
                     properties:
                       cidrBlock:
                         description: 'CidrBlock is the CIDR block to be used when
-                          the provider creates a managed virtual network. DEPRECATED:
+                          the provider creates a managed virtual network. Deprecated:
                           Use CIDRBlocks instead'
                         type: string
                       cidrBlocks:

config/crd/bases/infrastructure.cluster.x-k8s.io_azuremachines.yaml

@@ -87,7 +87,7 @@ spec:
                   public ips for machines where this value is true.
                 type: boolean
               availabilityZone:
-                description: 'DEPRECATED: use FailureDomain instead'
+                description: 'Deprecated: use FailureDomain instead'
                 properties:
                   enabled:
                     type: boolean
@@ -258,7 +258,7 @@ spec:
                     type: object
                 type: object
               location:
-                description: 'DEPRECATED: to support old clients, will be removed
+                description: 'Deprecated: to support old clients, will be removed
                   in v1alpha4/v1beta1'
                 type: string
               osDisk:

config/crd/bases/infrastructure.cluster.x-k8s.io_azuremachinetemplates.yaml

@@ -67,7 +67,7 @@ spec:
                           dynamic public ips for machines where this value is true.
                         type: boolean
                       availabilityZone:
-                        description: 'DEPRECATED: use FailureDomain instead'
+                        description: 'Deprecated: use FailureDomain instead'
                         properties:
                           enabled:
                             type: boolean
@@ -246,7 +246,7 @@ spec:
                             type: object
                         type: object
                       location:
-                        description: 'DEPRECATED: to support old clients, will be
+                        description: 'Deprecated: to support old clients, will be
                           removed in v1alpha4/v1beta1'
                         type: string
                       osDisk: