Skip to content

Commit 4b56596

Browse files
committed
remove using a different SP identity test
1 parent d49cbc7 commit 4b56596

File tree

4 files changed

+4
-146
lines changed

4 files changed

+4
-146
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.16
44

55
require (
66
github.com/Azure/aad-pod-identity v1.8.0
7-
github.com/Azure/azure-sdk-for-go v53.1.0+incompatible
7+
github.com/Azure/azure-sdk-for-go v55.2.0+incompatible
88
github.com/Azure/go-autorest/autorest v0.11.18
99
github.com/Azure/go-autorest/autorest/adal v0.9.13
1010
github.com/Azure/go-autorest/autorest/azure/auth v0.5.3

go.sum

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ contrib.go.opencensus.io/exporter/prometheus v0.1.0/go.mod h1:cGFniUXGZlKRjzOyuZ
4343
dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
4444
github.com/Azure/aad-pod-identity v1.8.0 h1:VrVNJ5fL1NudN3+DnHAHkjSBxHnP/jZnFyxXBE36eyg=
4545
github.com/Azure/aad-pod-identity v1.8.0/go.mod h1:z1+AHOskemFNCHmSdtF3DMqw6mBb/Va7/wLY9+4Aauk=
46+
github.com/Azure/azure-sdk-for-go v16.2.1+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
4647
github.com/Azure/azure-sdk-for-go v40.4.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
4748
github.com/Azure/azure-sdk-for-go v55.2.0+incompatible h1:TL2/vJWJEPOrmv97nHcbvjXES0Ntlb9P95hqGA1J2dU=
4849
github.com/Azure/azure-sdk-for-go v55.2.0+incompatible/go.mod h1:9XXNKU+eRnpl9moKnB4QOLf1HestfXbmab5FXxiDBjc=
@@ -54,7 +55,6 @@ github.com/Azure/go-autorest v14.2.0+incompatible/go.mod h1:r+4oMnoxhatjLLJ6zxSW
5455
github.com/Azure/go-autorest/autorest v0.1.0/go.mod h1:AKyIcETwSUFxIcs/Wnq/C+kwCtlEYGUVd7FPNb2slmg=
5556
github.com/Azure/go-autorest/autorest v0.9.0/go.mod h1:xyHB1BMZT0cuDHU7I0+g046+BFDTQ8rEZB0s4Yfa6bI=
5657
github.com/Azure/go-autorest/autorest v0.9.6/go.mod h1:/FALq9T/kS7b5J5qsQ+RSTUdAmGFqi0vUdVNNx8q630=
57-
github.com/Azure/go-autorest/autorest v0.10.0/go.mod h1:/FALq9T/kS7b5J5qsQ+RSTUdAmGFqi0vUdVNNx8q630=
5858
github.com/Azure/go-autorest/autorest v0.11.1/go.mod h1:JFgpikqFJ/MleTTxwepExTKnFUKKszPS8UavbQYUMuw=
5959
github.com/Azure/go-autorest/autorest v0.11.9/go.mod h1:eipySxLmqSyC5s5k1CLupqet0PSENBEDP93LQ9a8QYw=
6060
github.com/Azure/go-autorest/autorest v0.11.12/go.mod h1:eipySxLmqSyC5s5k1CLupqet0PSENBEDP93LQ9a8QYw=
@@ -1253,6 +1253,7 @@ golang.org/x/sys v0.0.0-20200511232937-7e40ca221e25/go.mod h1:h1NjWce9XRLGQEsW7w
12531253
golang.org/x/sys v0.0.0-20200515095857-1151b9dac4a9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12541254
golang.org/x/sys v0.0.0-20200523222454-059865788121/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12551255
golang.org/x/sys v0.0.0-20200615200032-f1bc736245b1/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
1256+
golang.org/x/sys v0.0.0-20200622214017-ed371f2e16b4/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12561257
golang.org/x/sys v0.0.0-20200625212154-ddb9806d33ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12571258
golang.org/x/sys v0.0.0-20200728102440-3e129f6d46b1/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
12581259
golang.org/x/sys v0.0.0-20200803210538-64077c9b5642/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=

test/e2e/azure_identity.go

Lines changed: 0 additions & 66 deletions
This file was deleted.

test/e2e/azure_test.go

Lines changed: 1 addition & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ var _ = Describe("Workload cluster creation", func() {
329329
})
330330

331331
Context("Cordon and draining a node", func() {
332-
AzureMachinePoolDrainSpec(ctx, func() AzureMachinePoolDrainSpecInput{
332+
AzureMachinePoolDrainSpec(ctx, func() AzureMachinePoolDrainSpecInput {
333333
return AzureMachinePoolDrainSpecInput{
334334
BootstrapClusterProxy: bootstrapClusterProxy,
335335
Namespace: namespace,
@@ -430,85 +430,8 @@ var _ = Describe("Workload cluster creation", func() {
430430
})
431431
})
432432

433-
Context("Creating a cluster using a different SP identity", func() {
434-
BeforeEach(func() {
435-
spClientSecret := os.Getenv("AZURE_MULTI_TENANCY_SECRET")
436-
secret := &corev1.Secret{
437-
ObjectMeta: metav1.ObjectMeta{
438-
Name: "sp-identity-secret",
439-
Namespace: namespace.Name,
440-
},
441-
Type: corev1.SecretTypeOpaque,
442-
Data: map[string][]byte{"clientSecret": []byte(spClientSecret)},
443-
}
444-
err := bootstrapClusterProxy.GetClient().Create(ctx, secret)
445-
Expect(err).ToNot(HaveOccurred())
446-
})
447-
448-
It("with a single control plane node and 1 node", func() {
449-
spClientID := os.Getenv("AZURE_MULTI_TENANCY_ID")
450-
identityName := e2eConfig.GetVariable(MultiTenancyIdentityName)
451-
os.Setenv("CLUSTER_IDENTITY_NAME", identityName)
452-
os.Setenv("CLUSTER_IDENTITY_NAMESPACE", namespace.Name)
453-
os.Setenv("AZURE_CLUSTER_IDENTITY_CLIENT_ID", spClientID)
454-
os.Setenv("AZURE_CLUSTER_IDENTITY_SECRET_NAME", "sp-identity-secret")
455-
os.Setenv("AZURE_CLUSTER_IDENTITY_SECRET_NAMESPACE", namespace.Name)
456-
457-
clusterctl.ApplyClusterTemplateAndWait(ctx, clusterctl.ApplyClusterTemplateAndWaitInput{
458-
ClusterProxy: bootstrapClusterProxy,
459-
ConfigCluster: clusterctl.ConfigClusterInput{
460-
LogFolder: filepath.Join(artifactFolder, "clusters", bootstrapClusterProxy.GetName()),
461-
ClusterctlConfigPath: clusterctlConfigPath,
462-
KubeconfigPath: bootstrapClusterProxy.GetKubeconfigPath(),
463-
InfrastructureProvider: clusterctl.DefaultInfrastructureProvider,
464-
Flavor: "multi-tenancy",
465-
Namespace: namespace.Name,
466-
ClusterName: clusterName,
467-
KubernetesVersion: e2eConfig.GetVariable(capi_e2e.KubernetesVersion),
468-
ControlPlaneMachineCount: pointer.Int64Ptr(1),
469-
WorkerMachineCount: pointer.Int64Ptr(1),
470-
},
471-
WaitForClusterIntervals: e2eConfig.GetIntervals(specName, "wait-cluster"),
472-
WaitForControlPlaneIntervals: e2eConfig.GetIntervals(specName, "wait-control-plane"),
473-
WaitForMachineDeployments: e2eConfig.GetIntervals(specName, "wait-worker-nodes"),
474-
}, result)
475-
476-
Context("Validating identity", func() {
477-
AzureServicePrincipalIdentitySpec(ctx, func() AzureServicePrincipalIdentitySpecInput {
478-
return AzureServicePrincipalIdentitySpecInput{
479-
BootstrapClusterProxy: bootstrapClusterProxy,
480-
Namespace: namespace,
481-
ClusterName: clusterName,
482-
}
483-
})
484-
})
485-
})
486-
})
487-
488433
Context("Creating an AKS cluster using a different SP identity", func() {
489-
BeforeEach(func() {
490-
spClientSecret := os.Getenv("AZURE_MULTI_TENANCY_SECRET")
491-
secret := &corev1.Secret{
492-
ObjectMeta: metav1.ObjectMeta{
493-
Name: "sp-identity-secret",
494-
Namespace: namespace.Name,
495-
},
496-
Type: corev1.SecretTypeOpaque,
497-
Data: map[string][]byte{"clientSecret": []byte(spClientSecret)},
498-
}
499-
err := bootstrapClusterProxy.GetClient().Create(ctx, secret)
500-
Expect(err).ToNot(HaveOccurred())
501-
})
502-
503434
It("with a single control plane node and 1 node", func() {
504-
spClientID := os.Getenv("AZURE_MULTI_TENANCY_ID")
505-
identityName := e2eConfig.GetVariable(MultiTenancyIdentityName)
506-
os.Setenv("CLUSTER_IDENTITY_NAME", identityName)
507-
os.Setenv("CLUSTER_IDENTITY_NAMESPACE", namespace.Name)
508-
os.Setenv("AZURE_CLUSTER_IDENTITY_CLIENT_ID", spClientID)
509-
os.Setenv("AZURE_CLUSTER_IDENTITY_SECRET_NAME", "sp-identity-secret")
510-
os.Setenv("AZURE_CLUSTER_IDENTITY_SECRET_NAMESPACE", namespace.Name)
511-
512435
kubernetesVersion, err := GetAKSKubernetesVersion(ctx, e2eConfig)
513436
Expect(err).To(BeNil())
514437

0 commit comments

Comments
 (0)