Merge pull request #4703 from nojnhuh/no-prealloc

k8s-ci-robot · web-flow · commit 529ae97b394a · 2024-04-09T19:17:21.000-07:00
skip prealloc linter
diff --git a/.golangci.yml b/.golangci.yml
@@ -42,7 +42,6 @@ linters:
     - noctx
     - nolintlint
     - nosprintfhostport
-    - prealloc
     - predeclared
     - reassign
     - revive
diff --git a/azure/services/subnets/spec.go b/azure/services/subnets/spec.go
@@ -97,8 +97,6 @@ func (s *SubnetSpec) Parameters(ctx context.Context, existing *asonetworkv1.Virt
 		}
 	}
 
-	//nolint:prealloc // pre-allocating this slice isn't going to make any meaningful performance difference
-	// and makes it harder to keep this value nil when s.ServiceEndpoints is empty as is necessary.
 	var serviceEndpoints []asonetworkv1.ServiceEndpointPropertiesFormat
 	for _, se := range s.ServiceEndpoints {
 		serviceEndpoints = append(serviceEndpoints, asonetworkv1.ServiceEndpointPropertiesFormat{Service: ptr.To(se.Service), Locations: se.Locations})

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,6 @@ func (s SubnetSpec) Parameters(ctx context.Context, existing asonetworkv1.Virt`
`97`	`97`	`}`
`98`	`98`	`}`
`99`	`99`
`100`		`- //nolint:prealloc // pre-allocating this slice isn't going to make any meaningful performance difference`
`101`		`- // and makes it harder to keep this value nil when s.ServiceEndpoints is empty as is necessary.`
`102`	`100`	`var serviceEndpoints []asonetworkv1.ServiceEndpointPropertiesFormat`
`103`	`101`	`for _, se := range s.ServiceEndpoints {`
`104`	`102`	`serviceEndpoints = append(serviceEndpoints, asonetworkv1.ServiceEndpointPropertiesFormat{Service: ptr.To(se.Service), Locations: se.Locations})`