refactor annotation name constants from api/v1beta1/tags.go

- add VMTagsLastAppliedAnnotation, RGTagsLastAppliedAnnotation to azure/const.go
- add deprecated message to the named constants

Author: nawazkh

api/v1beta1/tags.go

@@ -135,12 +135,14 @@ const (
 	// which tracks the AdditionalTags in the Machine Provider Config.
 	// See https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
 	// for annotation formatting rules.
+	// Deprecated: use azure.VMTagsLastAppliedAnnotation instead. This constant will be removed in v1beta2.
 	VMTagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-azure-last-applied-tags-vm"
 
 	// RGTagsLastAppliedAnnotation is the key for the Azure Cluster object annotation
 	// which tracks the AdditionalTags for Resource Group which is part in the Azure Cluster.
 	// See https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
 	// for annotation formatting rules.
+	// Deprecated: use azure.RGTagsLastAppliedAnnotation instead. This constant will be removed in v1beta2.
 	RGTagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-azure-last-applied-tags-rg"
 )
 

azure/const.go

@@ -0,0 +1,31 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package azure
+
+const (
+	// VMTagsLastAppliedAnnotation is the key for the machine object annotation
+	// which tracks the AdditionalTags in the Machine Provider Config.
+	// See https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
+	// for annotation formatting rules.
+	VMTagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-azure-last-applied-tags-vm"
+
+	// RGTagsLastAppliedAnnotation is the key for the Azure Cluster object annotation
+	// which tracks the AdditionalTags for Resource Group which is part in the Azure Cluster.
+	// See https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
+	// for annotation formatting rules.
+	RGTagsLastAppliedAnnotation = "sigs.k8s.io/cluster-api-provider-azure-last-applied-tags-rg"
+)

azure/scope/cluster.go

@@ -947,7 +947,7 @@ func (s *ClusterScope) TagsSpecs() []azure.TagsSpec {
 		{
 			Scope:      azure.ResourceGroupID(s.SubscriptionID(), s.ResourceGroup()),
 			Tags:       s.AdditionalTags(),
-			Annotation: infrav1.RGTagsLastAppliedAnnotation,
+			Annotation: azure.RGTagsLastAppliedAnnotation,
 		},
 	}
 }

azure/scope/machine.go

@@ -177,7 +177,7 @@ func (m *MachineScope) TagsSpecs() []azure.TagsSpec {
 		{
 			Scope:      azure.VMID(m.SubscriptionID(), m.ResourceGroup(), m.Name()),
 			Tags:       m.AdditionalTags(),
-			Annotation: infrav1.VMTagsLastAppliedAnnotation,
+			Annotation: azure.VMTagsLastAppliedAnnotation,
 		},
 	}
 }

azure/scope/managedcontrolplane.go

@@ -757,7 +757,7 @@ func (s *ManagedControlPlaneScope) TagsSpecs() []azure.TagsSpec {
 		{
 			Scope:      azure.ResourceGroupID(s.SubscriptionID(), s.ResourceGroup()),
 			Tags:       s.AdditionalTags(),
-			Annotation: infrav1.RGTagsLastAppliedAnnotation,
+			Annotation: azure.RGTagsLastAppliedAnnotation,
 		},
 	}
 }