Skip to content

Commit 59dc2ea

Browse files
committed
🐛 fix e2e with webhook
Signed-off-by: Alexander Eldeib <[email protected]>
1 parent 7cc71a1 commit 59dc2ea

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

test/e2e/azure_suite_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ var _ = AfterSuite(func() {
144144
// DO NOT stream "capi-controller-manager" logs as it prints out azure.json
145145
Expect(writeLogs(mgmt, "capi-kubeadm-bootstrap-system", "capi-kubeadm-bootstrap-controller-manager", logPath)).To(Succeed())
146146
Expect(writeLogs(mgmt, "capz-system", "capz-controller-manager", logPath)).To(Succeed())
147+
Expect(writeLogs(mgmt, "capi-webhook-system", "capz-controller-manager", logPath)).To(Succeed())
147148
By("Tearing down management cluster")
148149
mgmt.Teardown(ctx)
149150
})

test/e2e/azure_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ var _ = Describe("CAPZ e2e tests", func() {
5151
nodeGen = &NodeGenerator{}
5252
clusterGen.VariablesInit()
5353
machineDeploymentGen = &MachineDeploymentGenerator{}
54-
cluster, infraCluster = clusterGen.GenerateCluster(namespace)
5554
})
5655

5756
AfterEach(func() {
@@ -61,6 +60,7 @@ var _ = Describe("CAPZ e2e tests", func() {
6160

6261
Context("Create single controlplane cluster", func() {
6362
It("Should create a single node cluster", func() {
63+
cluster, infraCluster = clusterGen.GenerateCluster(creds.SubscriptionID, namespace)
6464
controlplane := nodeGen.GenerateKubeadmControlplane(creds, cluster.GetName(), 1)
6565
machineTemplate := nodeGen.GenerateMachineTemplate(creds, cluster.GetName())
6666
input = &ControlPlaneClusterInput{
@@ -77,6 +77,7 @@ var _ = Describe("CAPZ e2e tests", func() {
7777

7878
Context("Create multiple controlplane cluster with machine deployments", func() {
7979
It("Should create a 3 node cluster", func() {
80+
cluster, infraCluster = clusterGen.GenerateCluster(creds.SubscriptionID, namespace)
8081
controlplane := nodeGen.GenerateKubeadmControlplane(creds, cluster.GetName(), 3)
8182
machineTemplate := nodeGen.GenerateMachineTemplate(creds, cluster.GetName())
8283
machineDeployment := machineDeploymentGen.Generate(creds, cluster.GetNamespace(), cluster.GetName(), 1)

test/e2e/resource_generators.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func (c *ClusterGenerator) VariablesInit() {
117117
imageVersion = v.GetString("imageVersion")
118118
}
119119

120-
func (c *ClusterGenerator) GenerateCluster(namespace string) (*capiv1.Cluster, *infrav1.AzureCluster) {
120+
func (c *ClusterGenerator) GenerateCluster(subscriptionId, namespace string) (*capiv1.Cluster, *infrav1.AzureCluster) {
121121
name := "capz-e2e" + util.RandomString(6)
122122
vnetName := name + "-vnet"
123123
tags := map[string]string{
@@ -130,8 +130,9 @@ func (c *ClusterGenerator) GenerateCluster(namespace string) (*capiv1.Cluster, *
130130
Name: name,
131131
},
132132
Spec: infrav1.AzureClusterSpec{
133-
Location: location,
134-
ResourceGroup: name,
133+
Location: location,
134+
ResourceGroup: name,
135+
SubscriptionID: subscriptionId,
135136
NetworkSpec: infrav1.NetworkSpec{
136137
Vnet: infrav1.VnetSpec{Name: vnetName},
137138
},

0 commit comments

Comments
 (0)