Merge pull request #811 from CecileRobertMichon/refactor-role-assignments

💎 refactor role assignment service

Author: k8s-ci-robot

cloud/scope/machine.go

@@ -19,6 +19,7 @@ package scope
 import (
 	"context"
 	"encoding/base64"
+	"k8s.io/apimachinery/pkg/util/uuid"
 
 	"github.com/go-logr/logr"
 	"github.com/pkg/errors"
@@ -146,7 +147,7 @@ func (m *MachineScope) NICSpecs() []azure.NICSpec {
 	return specs
 }
 
-// DiskSpecs returns the public IP specs.
+// DiskSpecs returns the disk specs.
 func (m *MachineScope) DiskSpecs() []azure.DiskSpec {
 	spec := azure.DiskSpec{
 		Name: azure.GenerateOSDiskName(m.Name()),
@@ -155,6 +156,19 @@ func (m *MachineScope) DiskSpecs() []azure.DiskSpec {
 	return []azure.DiskSpec{spec}
 }
 
+// RoleAssignmentSpecs returns the role assignment specs.
+func (m *MachineScope) RoleAssignmentSpecs() []azure.RoleAssignmentSpec {
+	if m.AzureMachine.Spec.Identity == infrav1.VMIdentitySystemAssigned {
+		return []azure.RoleAssignmentSpec{
+			{
+				MachineName: m.Name(),
+				UUID:        string(uuid.NewUUID()),
+			},
+		}
+	}
+	return []azure.RoleAssignmentSpec{}
+}
+
 // Subnet returns the machine's subnet based on its role
 func (m *MachineScope) Subnet() *infrav1.SubnetSpec {
 	if m.IsControlPlane() {

cloud/services/roleassignments/mock_roleassignments/client_mock.go

@@ -15,6 +15,8 @@ limitations under the License.
 */
 
 // Run go generate to regenerate this mock.
-//go:generate ../../../../hack/tools/bin/mockgen -destination roleassignments_mock.go -package mock_roleassignments -source ../client.go Client
+//go:generate ../../../../hack/tools/bin/mockgen -destination client_mock.go -package mock_roleassignments -source ../client.go Client
+//go:generate ../../../../hack/tools/bin/mockgen -destination roleassignments_mock.go -package mock_roleassignments -source ../service.go RoleAssignmentScope
+//go:generate /usr/bin/env bash -c "cat ../../../../hack/boilerplate/boilerplate.generatego.txt client_mock.go > _client_mock.go && mv _client_mock.go client_mock.go"
 //go:generate /usr/bin/env bash -c "cat ../../../../hack/boilerplate/boilerplate.generatego.txt roleassignments_mock.go > _roleassignments_mock.go && mv _roleassignments_mock.go roleassignments_mock.go"
 package mock_roleassignments //nolint