fix: memory alias within a for loop

devigned · devigned · commit 6c7c5c69be0a · 2020-05-15T07:18:53.000-07:00
diff --git a/controllers/azuremachine_reconciler.go b/controllers/azuremachine_reconciler.go
@@ -346,6 +346,7 @@ func (s *azureMachineService) createVirtualMachine(nicName string) (*infrav1.VM,
 func GetControlPlaneMachines(machineList *clusterv1.MachineList) []*clusterv1.Machine {
 	var cpm []*clusterv1.Machine
 	for _, m := range machineList.Items {
+		m := m
 		if util.IsControlPlaneMachine(&m) {
 			cpm = append(cpm, m.DeepCopy())
 		}

Original file line number	Diff line number	Diff line change
`@@ -346,6 +346,7 @@ func (s azureMachineService) createVirtualMachine(nicName string) (infrav1.VM,`
`346`	`346`	`func GetControlPlaneMachines(machineList clusterv1.MachineList) []clusterv1.Machine {`
`347`	`347`	`var cpm []*clusterv1.Machine`
`348`	`348`	`for _, m := range machineList.Items {`
	`349`	`+ m := m`
`349`	`350`	`if util.IsControlPlaneMachine(&m) {`
`350`	`351`	`cpm = append(cpm, m.DeepCopy())`
`351`	`352`	`}`