Skip to content

Commit 7979a97

Browse files
authored
Merge pull request #2016 from jsturtevant/revert-image-gallery
Revert #1993 - Continue to use image gallery for the e2e test on Windows
2 parents fc9a60f + 1535f20 commit 7979a97

File tree

7 files changed

+34
-41
lines changed

7 files changed

+34
-41
lines changed

templates/test/ci/cluster-template-prow-ci-version-windows-containerd-2022.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -401,12 +401,11 @@ spec:
401401
template:
402402
spec:
403403
image:
404-
sharedGallery:
405-
gallery: CAPZTestingImages
406-
name: capi-windows-2022-containerd
407-
resourceGroup: capz-ci
408-
subscriptionID: ${AZURE_SUBSCRIPTION_ID}
409-
version: 0.3.1642811382
404+
marketplace:
405+
offer: capi-windows
406+
publisher: cncf-upstream
407+
sku: k8s-1dot23dot3-windows-2022-containerd
408+
version: latest
410409
osDisk:
411410
diskSizeGB: 128
412411
managedDisk:

templates/test/ci/cluster-template-prow-ci-version.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -401,12 +401,11 @@ spec:
401401
template:
402402
spec:
403403
image:
404-
sharedGallery:
405-
gallery: CAPZTestingImages
406-
name: capi-windows-2019-containerd
407-
resourceGroup: capz-ci
408-
subscriptionID: ${AZURE_SUBSCRIPTION_ID}
409-
version: 0.3.1643001114
404+
marketplace:
405+
offer: capi-windows
406+
publisher: cncf-upstream
407+
sku: k8s-1dot23dot3-windows-2019-containerd
408+
version: latest
410409
osDisk:
411410
diskSizeGB: 128
412411
managedDisk:

templates/test/ci/prow-ci-version-windows-containerd-2022/patches/windows-image-update.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ spec:
77
template:
88
spec:
99
image:
10-
sharedGallery:
11-
resourceGroup: "capz-ci"
12-
name: "capi-windows-2022-containerd"
13-
subscriptionID: "${AZURE_SUBSCRIPTION_ID}"
14-
gallery: "CAPZTestingImages"
15-
version: "0.3.1642811382"
10+
# we use the an older image as a workaround there is no published marketplace image for k8s CI versions.
11+
# the binaries and images will get replaced to the desired version by the pre-kubeadm script.
12+
marketplace:
13+
publisher: cncf-upstream
14+
offer: capi-windows
15+
sku: k8s-1dot23dot3-windows-2022-containerd
16+
version: "latest"

templates/test/ci/prow-ci-version/kustomization.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ patchesStrategicMerge:
1111
- ../patches/windows-containerd-patch.yaml
1212
- ../patches/machine-deployment-worker-counts.yaml
1313
- patches/machine-deployment-ci-version.yaml
14+
- patches/machine-deployment-ci-version-windows.yaml
1415
- ../patches/metrics-server-enabled-cluster.yaml
1516
- patches/controller-manager-featuregates.yaml
1617
- ../patches/windows-containerd-enabled-cluster.yaml
17-
- patches/machine-deployment-ci-version-windows-shared-gallery.yaml
1818
patches:
1919
- target:
2020
group: bootstrap.cluster.x-k8s.io
@@ -36,12 +36,6 @@ patches:
3636
kind: KubeadmControlPlane
3737
name: .*-control-plane
3838
path: ../patches/control-plane-kubeadm-boostrap-ci-version.yaml
39-
- target:
40-
group: infrastructure.cluster.x-k8s.io/v1beta1
41-
version: v1beta1
42-
kind: AzureMachineTemplate
43-
name: ${CLUSTER_NAME}-md-win
44-
path: patches/drop-machine-deployment-windows-image-marketplace.yaml
4539
configMapGenerator:
4640
- name: cni-${CLUSTER_NAME}-calico
4741
behavior: merge

templates/test/ci/prow-ci-version/patches/drop-machine-deployment-windows-image-marketplace.yaml

Lines changed: 0 additions & 2 deletions
This file was deleted.

templates/test/ci/prow-ci-version/patches/machine-deployment-ci-version-windows-shared-gallery.yaml

Lines changed: 0 additions & 14 deletions
This file was deleted.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
2+
kind: AzureMachineTemplate
3+
metadata:
4+
name: ${CLUSTER_NAME}-md-win
5+
spec:
6+
template:
7+
spec:
8+
image:
9+
# we use the an older image as a workaround there is no published marketplace image for k8s CI versions.
10+
# the binaries and images will get replaced to the desired version by the pre-kubeadm script.
11+
marketplace:
12+
publisher: cncf-upstream
13+
offer: capi-windows
14+
sku: k8s-1dot23dot3-windows-2019-containerd
15+
version: "latest"
16+

0 commit comments

Comments
 (0)