Skip to content

Commit 887464d

Browse files
lzhechengCecileRobertMichon
authored andcommitted
[e2e] Support more flexible env var for cloud-provider-azure
Signed-off-by: Zhecheng Li <[email protected]>
1 parent 940d269 commit 887464d

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

scripts/ci-build-azure-ccm.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ setup() {
4848

4949
# the azure-cloud-provider repo expects IMAGE_REGISTRY.
5050
export IMAGE_REGISTRY=${REGISTRY}
51-
pushd "${AZURE_CLOUD_PROVIDER_ROOT}" && IMAGE_TAG=$(git rev-parse --short=7 HEAD) && export IMAGE_TAG && popd
51+
pushd "${AZURE_CLOUD_PROVIDER_ROOT}" && IMAGE_TAG=$(git rev-parse --short=7 HEAD) &&
52+
IMAGE_TAG_CCM="${IMAGE_TAG_CCM:-${IMAGE_TAG}}" && IMAGE_TAG_CNM="${IMAGE_TAG_CNM:-${IMAGE_TAG}}" &&
53+
export IMAGE_TAG && export IMAGE_TAG_CCM && export IMAGE_TAG_CNM && popd
5254
echo "Image registry is ${REGISTRY}"
5355
echo "Image Tag is ${IMAGE_TAG}"
5456

scripts/ci-e2e.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,13 @@ if [[ "${BUILD_MANAGER_IMAGE}" == "true" ]]; then
5757
export TAG="${defaultTag:-dev}"
5858
fi
5959

60+
if [[ "$(capz::util::should_build_ccm)" == "true" ]]; then
61+
# shellcheck source=scripts/ci-build-azure-ccm.sh
62+
source "${REPO_ROOT}/scripts/ci-build-azure-ccm.sh"
63+
echo "Will use the ${IMAGE_REGISTRY}/${CCM_IMAGE_NAME}:${IMAGE_TAG} cloud-controller-manager image for external cloud-provider-cluster"
64+
echo "Will use the ${IMAGE_REGISTRY}/${CNM_IMAGE_NAME}:${IMAGE_TAG} cloud-node-manager image for external cloud-provider-azure cluster"
65+
fi
66+
6067
export GINKGO_NODES=10
6168

6269
export AZURE_LOCATION="${AZURE_LOCATION:-$(capz::util::get_random_region)}"

test/e2e/cloud-provider-azure.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ func InstallCalicoAndCloudProviderAzureHelmChart(ctx context.Context, input clus
5454
options.Values = append(options.Values, fmt.Sprintf("cloudNodeManager.imageName=%s", os.Getenv("CNM_IMAGE_NAME")))
5555
options.Values = append(options.Values, fmt.Sprintf("cloudControllerManager.imageRepository=%s", os.Getenv("IMAGE_REGISTRY")))
5656
options.Values = append(options.Values, fmt.Sprintf("cloudNodeManager.imageRepository=%s", os.Getenv("IMAGE_REGISTRY")))
57-
options.StringValues = append(options.StringValues, fmt.Sprintf("cloudControllerManager.imageTag=%s", os.Getenv("IMAGE_TAG")))
58-
options.StringValues = append(options.StringValues, fmt.Sprintf("cloudNodeManager.imageTag=%s", os.Getenv("IMAGE_TAG")))
57+
options.StringValues = append(options.StringValues, fmt.Sprintf("cloudControllerManager.imageTag=%s", os.Getenv("IMAGE_TAG_CCM")))
58+
options.StringValues = append(options.StringValues, fmt.Sprintf("cloudNodeManager.imageTag=%s", os.Getenv("IMAGE_TAG_CNM")))
5959
}
6060

6161
clusterProxy := input.ClusterProxy.GetWorkloadCluster(ctx, input.ConfigCluster.Namespace, input.ConfigCluster.ClusterName)

0 commit comments

Comments
 (0)