Skip to content

Commit a52056d

Browse files
authored
Merge pull request #4926 from jackfrancis/tilt-asoapi
set EXP_ASO_API=true for CI
2 parents 772d354 + cab67d2 commit a52056d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ create-cluster: ## Create a workload development Kubernetes cluster on Azure in
375375
EXP_CLUSTER_RESOURCE_SET=true \
376376
EXP_MACHINE_POOL=true \
377377
EXP_EDGEZONE=true \
378+
EXP_ASO_API=true \
378379
$(MAKE) create-management-cluster \
379380
create-workload-cluster
380381

@@ -730,7 +731,7 @@ tilt-up: install-tools kind-create ## Start tilt and build kind cluster if neede
730731
@if [ -z "${AZURE_CLIENT_ID_USER_ASSIGNED_IDENTITY}" ]; then \
731732
export AZURE_CLIENT_ID_USER_ASSIGNED_IDENTITY=$(shell cat $(AZURE_IDENTITY_ID_FILEPATH)); \
732733
fi; \
733-
CLUSTER_TOPOLOGY=true EXP_CLUSTER_RESOURCE_SET=true EXP_MACHINE_POOL=true EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION=true EXP_EDGEZONE=true tilt up
734+
CLUSTER_TOPOLOGY=true EXP_ASO_API=true EXP_CLUSTER_RESOURCE_SET=true EXP_MACHINE_POOL=true EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION=true EXP_EDGEZONE=true tilt up
734735

735736
.PHONY: delete-cluster
736737
delete-cluster: delete-workload-cluster ## Deletes the example kind cluster "capz".

hack/observability/opentelemetry/controller-manager-patch.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ spec:
1212
- "--diagnostics-address=:8080"
1313
- "--insecure-diagnostics"
1414
- "--leader-elect"
15-
- "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=false},AKSResourceHealth=${EXP_AKS_RESOURCE_HEALTH:=false},EdgeZone=${EXP_EDGEZONE:=false},ASOAPI=${EXP_ASO_API:=false}"
15+
- "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=false},AKSResourceHealth=${EXP_AKS_RESOURCE_HEALTH:=false},EdgeZone=${EXP_EDGEZONE:=false},ASOAPI=${EXP_ASO_API:=true}"
1616
- "--enable-tracing"

templates/flavors/aks-aso/credentials.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ metadata:
55
stringData:
66
AZURE_SUBSCRIPTION_ID: ${AZURE_SUBSCRIPTION_ID}
77
AZURE_TENANT_ID: ${AZURE_TENANT_ID}
8-
AZURE_CLIENT_ID: ${AZURE_CLIENT_ID}
9-
AUTH_MODE: ${ASO_CREDENTIAL_SECRET_MODE}
8+
AZURE_CLIENT_ID: ${AZURE_CLIENT_ID_USER_ASSIGNED_IDENTITY}
9+
AUTH_MODE: ${ASO_CREDENTIAL_SECRET_MODE:-workloadidentity}

0 commit comments

Comments
 (0)