Skip to content

Commit b27fdaf

Browse files
authored
Merge pull request #620 from CecileRobertMichon/api-diff
🏃 Add ci-apidiff job
2 parents 53b643a + d71f5f0 commit b27fdaf

File tree

2 files changed

+34
-0
lines changed

2 files changed

+34
-0
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ KUBECTL=$(TOOLS_BIN_DIR)/kubectl
5151
KUSTOMIZE := $(TOOLS_BIN_DIR)/kustomize
5252
MOCKGEN := $(TOOLS_BIN_DIR)/mockgen
5353
RELEASE_NOTES := $(TOOLS_BIN_DIR)/release-notes
54+
GO_APIDIFF := $(TOOLS_BIN_DIR)/go-apidiff
5455
EXP_DIR := exp
5556

5657
# Define Docker related variables. Releases should modify and double check these vars.
@@ -148,6 +149,9 @@ $(RELEASE_NOTES): ## Build release notes
148149
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) sigs.k8s.io/cluster-api/hack/tools/release
149150
mv $(TOOLS_BIN_DIR)/release $(RELEASE_NOTES)
150151

152+
$(GO_APIDIFF): ## Build go-apidiff.
153+
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) github.com/joelanford/go-apidiff
154+
151155
## --------------------------------------
152156
## Linting
153157
## --------------------------------------

scripts/ci-apidiff.sh

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
#!/bin/bash
2+
3+
# Copyright 2020 The Kubernetes Authors.
4+
#
5+
# Licensed under the Apache License, Version 2.0 (the "License");
6+
# you may not use this file except in compliance with the License.
7+
# You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
17+
set -o errexit
18+
set -o nounset
19+
set -o pipefail
20+
21+
REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
22+
cd "${REPO_ROOT}"
23+
24+
APIDIFF="${PWD}/hack/tools/bin/go-apidiff"
25+
PULL_BASE_SHA=${PULL_BASE_SHA:-$(git rev-parse origin/master)}
26+
27+
make ${APIDIFF}
28+
echo "*** Running go-apidiff ***"
29+
30+
${APIDIFF} "${PULL_BASE_SHA}" --print-compatible

0 commit comments

Comments
 (0)