Merge pull request #5238 from nojnhuh/no-prealloc-deux

skip prealloc linter

Author: k8s-ci-robot

.golangci.yml

@@ -39,7 +39,8 @@ linters:
     - noctx # http requests without context.Context
     - nolintlint # badly formatted nolint directives
     - nosprintfhostport # using sprintf to construct host:port in a URL
-    - prealloc # suggest preallocating slices
+    # We don't want to use this one: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4703
+    # - prealloc # suggest preallocating slices
     - predeclared # shadowing predeclared identifiers
     - revive # better version of golint
     - staticcheck # some of staticcheck's rules

azure/services/subnets/spec.go

@@ -98,8 +98,7 @@ func (s *SubnetSpec) Parameters(_ context.Context, existing *asonetworkv1.Virtua
 		}
 	}
 
-	// TODO (nojnhuh) : do we want to initialize serviceEndpoints with an empty slice instead?
-	var serviceEndpoints []asonetworkv1.ServiceEndpointPropertiesFormat //nolint:prealloc // leaving it as is for now
+	var serviceEndpoints []asonetworkv1.ServiceEndpointPropertiesFormat
 	for _, se := range s.ServiceEndpoints {
 		serviceEndpoints = append(serviceEndpoints, asonetworkv1.ServiceEndpointPropertiesFormat{Service: ptr.To(se.Service), Locations: se.Locations})
 	}

controllers/resource_reconciler.go

@@ -63,10 +63,7 @@ func (r *ResourceReconciler) Reconcile(ctx context.Context) error {
 	defer done()
 	log.V(4).Info("reconciling resources")
 
-	// TODO (nojnhuh) : is there a functional diff between
-	// var newResourceStatuses []infrav1alpha.ResourceStatus and newResourceStatuses := make([]infrav1alpha.ResourceStatus,0)
-	// in the scenario below?
-	var newResourceStatuses []infrav1alpha.ResourceStatus //nolint:prealloc // leaving it as is for now
+	var newResourceStatuses []infrav1alpha.ResourceStatus
 
 	for _, spec := range r.resources {
 		gvk := spec.GroupVersionKind()