Skip to content

Commit b33199c

Browse files
committed
Add make verify/test to pre-push pre-commit config
This commit adds the same checks run in `make verify` without duplicating any previous hook runs in pre-commit to the pre-commit configuration. In addition, this commit adds `make test` to the pre-push stage of the pre-commit configuration. This will ensure `verify` and `test` are successfully passing before the commit is pushed. This will help reduce time and test resources by preventing `verify` and `test` from failing on the pull request in GitHub. Signed-off-by: Bryan Cox <[email protected]>
1 parent b596029 commit b33199c

File tree

1 file changed

+32
-0
lines changed

1 file changed

+32
-0
lines changed

.pre-commit-config.yaml

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,35 @@ repos:
3232
hooks:
3333
- id: forbid-binary
3434
stages: [pre-commit]
35+
- repo: local
36+
hooks:
37+
- id: make-modules
38+
name: Run make verify-modules
39+
entry: make verify-modules
40+
language: system
41+
stages: [pre-push]
42+
- id: make-gen
43+
name: Run make verify-gen
44+
entry: make verify-gen
45+
language: system
46+
stages: [pre-push]
47+
- id: make-spellcheck
48+
name: Run make verify-shellcheck
49+
entry: make verify-shellcheck
50+
language: system
51+
stages: [ pre-push ]
52+
- id: make-conversions
53+
name: Run make verify-conversions
54+
entry: make verify-conversions
55+
language: system
56+
stages: [ pre-push ]
57+
- id: make-tiltfile
58+
name: Run make verify-tiltfile
59+
entry: make verify-tiltfile
60+
language: system
61+
stages: [ pre-push ]
62+
- id: make-test
63+
name: Run make test
64+
entry: make test
65+
language: system
66+
stages: [pre-push]

0 commit comments

Comments
 (0)