Skip to content

Commit b988b40

Browse files
committed
Cherry-picking 1d6c199 into release-1.8
Signed-off-by: Mark Rossetti <[email protected]>
1 parent 43af41a commit b988b40

27 files changed

+7
-61
lines changed

docs/book/src/topics/windows.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ The Windows HostProcess Container feature is Alpha for Kubernetes v1.22 and Beta
8181

8282
Current requirements:
8383

84-
- Kubernetes 1.22+
84+
- Kubernetes 1.23+
8585
- containerd 1.6+
86-
- `WindowsHostProcessContainers` feature-gate (Alpha for v1.22) turned on for kube-apiserver and kubelet if using Kubernetes 1.22
86+
- `WindowsHostProcessContainers` feature-gate (Beta / on-by-default for v1.23) turned on for kube-apiserver and kubelet
8787

8888
These requirements are satisfied by the Windows Containerd Template and Azure Marketplace reference image `cncf-upstream:capi-windows:k8s-1dot22dot1-windows-2019-containerd:2021.10.15`
8989

scripts/ci-entrypoint.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,7 @@ setup() {
102102
export CCM_COUNT="${CCM_COUNT:-1}"
103103
export WORKER_MACHINE_COUNT="${WORKER_MACHINE_COUNT:-2}"
104104
export EXP_CLUSTER_RESOURCE_SET="true"
105-
# this requires k8s 1.22+
106-
if [[ -n "${K8S_FEATURE_GATES:-}" ]]; then
107-
export K8S_FEATURE_GATES="${K8S_FEATURE_GATES:-},WindowsHostProcessContainers=true"
108-
else
109-
export K8S_FEATURE_GATES="WindowsHostProcessContainers=true"
110-
fi
111-
105+
112106
# TODO figure out a better way to account for expected Windows node count
113107
if [[ -n "${TEST_WINDOWS:-}" ]]; then
114108
export WINDOWS_WORKER_MACHINE_COUNT="${WINDOWS_WORKER_MACHINE_COUNT:-2}"

templates/cluster-template-machinepool-windows.yaml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/cluster-template-windows.yaml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/flavors/base-windows-containerd/kubeadm-control-plane.yaml

Lines changed: 0 additions & 10 deletions
This file was deleted.

templates/flavors/machinepool-windows/kustomization.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@ resources:
44
- machine-pool-deployment-windows.yaml
55

66
patchesStrategicMerge:
7-
- ../base-windows-containerd/kubeadm-control-plane.yaml
87
- ../base-windows-containerd/cluster.yaml

templates/flavors/machinepool-windows/machine-pool-deployment-windows.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ spec:
6161
azure-container-registry-config: 'c:/k/azure.json'
6262
cloud-provider: external
6363
pod-infra-container-image: "mcr.microsoft.com/oss/kubernetes/pause:3.9"
64-
feature-gates: "WindowsHostProcessContainers=true"
6564
files:
6665
- contentFrom:
6766
secret:

templates/flavors/windows/kustomization.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ resources:
44
- machine-deployment-windows.yaml
55

66
patchesStrategicMerge:
7-
- ../base-windows-containerd/kubeadm-control-plane.yaml
87
- ../base-windows-containerd/cluster.yaml
98

templates/flavors/windows/machine-deployment-windows.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ spec:
6565
kubeletExtraArgs:
6666
azure-container-registry-config: 'c:/k/azure.json'
6767
cloud-provider: external
68-
feature-gates: "WindowsHostProcessContainers=true"
6968
v: "2"
7069
windows-priorityclass: "ABOVE_NORMAL_PRIORITY_CLASS"
7170
files:

templates/test/ci/cluster-template-prow-ci-version-windows-containerd-2022.yaml

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)