Merge pull request #281 from justaugustus/v1alpha2-reintegrate

Deploy Azure clusters via v1alpha2 APIs

Author: justaugustus

.bazelrc

@@ -1,5 +1,10 @@
-generatedconfigs/
-.env
-kubeconfig
-minikube.kubeconfig
-.travis.yml
+.git
+.github
+.vscode
+bin/
+config/
+hack/
+docs/
+examples/
+scripts/
+**/.md

.dockerignore

@@ -24,32 +24,22 @@ bin
 envfile
 
 # kubeconfigs
-/kind.kubeconfig
-/minikube.kubeconfig
-/kubeconfig
-
-# binaries
-/manager
-/clusterctl
-/clusterazureadm
+kind.kubeconfig
+minikube.kubeconfig
+kubeconfig
 
 # Example and binary output directory
 /out
 
-# bazel
-/bazel-bin
-/bazel-cluster-api-provider-azure
-/bazel-genfiles
-/bazel-out
-/bazel-testlogs
-
 # vscode
 .vscode
-.idea
 
 # goland
 .idea
 
 # Ignore output manifests
-cmd/clusterctl/examples/azure/out
-cmd/clusterctl/examples/azure/provider-components-base.yaml
+examples/_out
+examples/provider-components-base.yaml
+examples/provider-components/provider-components-*.yaml
+config/samples
+manager_image_patch.yaml-e

.gitignore

@@ -1,23 +1,15 @@
-linters-settings:
-  govet:
-    check-shadowing: true
-  gocyclo:
-    min-complexity: 19
-  maligned:
-    suggest-new: true
 linters:
   enable:
     - golint
     - govet
     - gofmt
-    - goimports
     - structcheck
     - varcheck
     - interfacer
     - unconvert
     - ineffassign
     - goconst
-    - gocyclo
+    # - gocyclo
     - maligned
     - misspell
     - nakedret

.golangci.yml

@@ -1,20 +1,74 @@
 # Contributing Guidelines
+<!-- START doctoc generated TOC please keep comment here to allow auto update -->
+<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 
-Welcome to Kubernetes. We are excited about the prospect of you joining our [community](https://github.com/kubernetes/community)! The Kubernetes community abides by the CNCF [code of conduct](code-of-conduct.md). Here is an excerpt:
 
-_As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities._
+- [Contributor License Agreements](#contributor-license-agreements)
+- [Finding Things That Need Help](#finding-things-that-need-help)
+- [Contributing a Patch](#contributing-a-patch)
+- [Backporting a Patch](#backporting-a-patch)
+  - [Merge Approval](#merge-approval)
+  - [Google Doc Viewing Permissions](#google-doc-viewing-permissions)
+  - [Issue and Pull Request Management](#issue-and-pull-request-management)
 
-## Getting Started
+<!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
-We have full documentation on how to get started contributing here:
+Read the following guide if you're interested in contributing to cluster-api.
 
-<!---
-If your repo has certain guidelines for contribution, put them here ahead of the general k8s resources
--->
+## Contributor License Agreements
 
-- [Contributor License Agreement](https://git.k8s.io/community/CLA.md) Kubernetes projects require that you sign a Contributor License Agreement (CLA) before we can accept your pull requests
-- [Kubernetes Contributor Guide](http://git.k8s.io/community/contributors/guide) - Main contributor documentation, or you can just jump directly to the [contributing section](http://git.k8s.io/community/contributors/guide#contributing)
-- [Contributor Cheat Sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet.md) - Common resources for existing developers
+We'd love to accept your patches! Before we can take them, we have to jump a couple of legal hurdles.
+
+Please fill out either the individual or corporate Contributor License Agreement (CLA). More information about the CLA and instructions for signing it [can be found here](https://github.com/kubernetes/community/blob/master/CLA.md).
+
+***NOTE***: Only original source code from you and other people that have signed the CLA can be accepted into the repository.
+
+## Finding Things That Need Help
+
+If you're new to the project and want to help, but don't know where to start, we have a semi-curated list of issues that should not need deep knowledge of the system. [Have a look and see if anything sounds interesting](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22). Alternatively, read some of the docs on other controllers and try to write your own, file and fix any/all issues that come up, including gaps in documentation!
+
+## Contributing a Patch
+
+1. If you haven't already done so, sign a Contributor License Agreement (see details above).
+1. Fork the desired repo, develop and test your code changes.
+1. Submit a pull request.
+  1. All code PR must be labeled with
+    ⚠️ (:warning:, major or breaking changes), ✨ (:sparkles:, minor or feature additions), 🐛 (:bug:, patch and bugfixes), 📖 (:book:, documentation or proposals), or 🏃 (:running:, other)
+
+All changes must be code reviewed. Coding conventions and standards are explained in the official [developer docs](https://github.com/kubernetes/community/tree/master/contributors/devel). Expect reviewers to request that you avoid common [go style mistakes](https://github.com/golang/go/wiki/CodeReviewComments) in your PRs.
+
+## Backporting a Patch
+
+Cluster API ships older versions through `release-X.X` branches, usually backports are reserved to critical bug-fixes.
+Some release branches might ship with both Go modules and dep (e.g. `release-0.1`), users backporting patches should always make sure
+that the vendored Go modules dependencies match the Gopkg.lock and Gopkg.toml ones by running `dep ensure`
+
+### Merge Approval
+
+Cluster API maintainers may add "LGTM" (Looks Good To Me) or an equivalent comment to indicate that a PR is acceptable. Any change requires at least one LGTM.  No pull requests can be merged until at least one Cluster API maintainer signs off with an LGTM.
+
+### Google Doc Viewing Permissions
+
+To gain viewing permissions to google docs in this project, please join either the [kubernetes-dev](https://groups.google.com/forum/#!forum/kubernetes-dev) or [kubernetes-sig-cluster-lifecycle](https://groups.google.com/forum/#!forum/kubernetes-sig-cluster-lifecycle) google group.
+
+### Issue and Pull Request Management
+
+Anyone may comment on issues and submit reviews for pull requests. However, in
+order to be assigned an issue or pull request, you must be a member of the
+[Kubernetes SIGs](https://github.com/kubernetes-sigs) GitHub organization.
+
+If you are a Kubernetes GitHub organization member, you are eligible for
+membership in the Kubernetes SIGs GitHub organization and can request
+membership by [opening an issue](https://github.com/kubernetes/org/issues/new?template=membership.md&title=REQUEST%3A%20New%20membership%20for%20%3Cyour-GH-handle%3E)
+against the kubernetes/org repo.
+
+However, if you are a member of any of the related Kubernetes GitHub
+organizations but not of the Kubernetes org, you will need explicit sponsorship
+for your membership request. You can read more about Kubernetes membership and
+sponsorship [here](https://github.com/kubernetes/community/blob/master/community-membership.md).
+
+Cluster API maintainers can assign you an issue or pull request by leaving a
+`/assign <your Github ID>` comment on the issue or pull request.
 
 ## Mentorship
 

BUILD.bazel

@@ -13,19 +13,32 @@
 # limitations under the License.
 
 # Build the manager binary
-FROM golang:1.12 as builder
+FROM golang:1.12.9 as builder
+WORKDIR /workspace
 
-# Copy in the go src
-WORKDIR /go/src/sigs.k8s.io/cluster-api-provider-azure
-COPY pkg/    pkg/
-COPY cmd/    cmd/
-COPY vendor/ vendor/
+# Run this with docker build --build_arg $(go env GOPROXY) to override the goproxy
+ARG goproxy=https://proxy.golang.org
+ENV GOPROXY=$goproxy
+
+# Copy the Go Modules manifests
+COPY go.mod go.mod
+COPY go.sum go.sum
+# Cache deps before building and copying source so that we don't need to re-download as much
+# and so that source changes don't invalidate our downloaded layer
+RUN go mod download
+
+# Copy the sources
+COPY ./ ./
 
 # Build
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/cluster-api-provider-azure/cmd/manager
+ARG ARCH
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=${ARCH} \
+    go build -a -ldflags '-extldflags "-static"' \
+    -o manager .
 
 # Copy the controller-manager into a thin image
-FROM gcr.io/distroless/base
-WORKDIR /root/
-COPY --from=builder /go/src/sigs.k8s.io/cluster-api-provider-azure/manager .
-ENTRYPOINT ["./manager"]
+FROM gcr.io/distroless/static:latest
+WORKDIR /
+COPY --from=builder /workspace/manager .
+USER nobody
+ENTRYPOINT ["/manager"]