Skip to content

Commit d73681a

Browse files
authored
Merge pull request #3305 from k8s-infra-cherrypick-robot/cherry-pick-3284-to-release-1.7
[release-1.7] CI: always build Linux and Windows images
2 parents 4e728f5 + a52bfdc commit d73681a

File tree

2 files changed

+12
-18
lines changed

2 files changed

+12
-18
lines changed

scripts/ci-build-azure-ccm.sh

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,8 @@ main() {
6161
if [[ "$(can_reuse_artifacts)" =~ "false" ]]; then
6262
echo "Build Linux Azure amd64 cloud controller manager"
6363
make -C "${AZURE_CLOUD_PROVIDER_ROOT}" build-ccm-image-amd64 push-ccm-image-amd64
64-
if [[ -n "${TEST_WINDOWS:-}" ]]; then
65-
echo "Building Linux amd64 and Windows ${WINDOWS_IMAGE_VERSION} amd64 cloud node managers"
64+
echo "Building Linux amd64 and Windows ${WINDOWS_IMAGE_VERSION} amd64 cloud node managers"
6665
make -C "${AZURE_CLOUD_PROVIDER_ROOT}" build-node-image-linux-amd64 push-node-image-linux-amd64 push-node-image-windows-"${WINDOWS_IMAGE_VERSION}"-amd64 manifest-node-manager-image-windows-"${WINDOWS_IMAGE_VERSION}"-amd64
67-
else
68-
echo "Building Linux amd64 cloud node manager"
69-
make -C "${AZURE_CLOUD_PROVIDER_ROOT}" build-node-image-linux-amd64 push-node-image-linux-push-name-amd64
70-
fi
7166
fi
7267
}
7368

@@ -79,13 +74,11 @@ can_reuse_artifacts() {
7974
fi
8075
done
8176

82-
if [[ -n "${TEST_WINDOWS:-}" ]]; then
83-
FULL_VERSION=$(docker manifest inspect mcr.microsoft.com/windows/nanoserver:${WINDOWS_IMAGE_VERSION} | jq -r '.manifests[0].platform["os.version"]')
84-
if ! docker manifest inspect "${REGISTRY}/${CNM_IMAGE_NAME}:${IMAGE_TAG}" | grep -q "\"os.version\": \"${FULL_VERSION}\""; then
85-
echo "false" && return
86-
fi
77+
FULL_VERSION=$(docker manifest inspect mcr.microsoft.com/windows/nanoserver:${WINDOWS_IMAGE_VERSION} | jq -r '.manifests[0].platform["os.version"]')
78+
if ! docker manifest inspect "${REGISTRY}/${CNM_IMAGE_NAME}:${IMAGE_TAG}" | grep -q "\"os.version\": \"${FULL_VERSION}\""; then
79+
echo "false" && return
8780
fi
88-
81+
8982
echo "true"
9083
}
9184

scripts/ci-entrypoint.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,16 @@ setup() {
9393
export CCM_COUNT="${CCM_COUNT:-1}"
9494
export WORKER_MACHINE_COUNT="${WORKER_MACHINE_COUNT:-2}"
9595
export EXP_CLUSTER_RESOURCE_SET="true"
96-
9796
# this requires k8s 1.22+
97+
if [[ -n "${K8S_FEATURE_GATES:-}" ]]; then
98+
export K8S_FEATURE_GATES="${K8S_FEATURE_GATES:-},WindowsHostProcessContainers=true"
99+
else
100+
export K8S_FEATURE_GATES="WindowsHostProcessContainers=true"
101+
fi
102+
103+
# TODO figure out a better way to account for expected Windows node count
98104
if [[ -n "${TEST_WINDOWS:-}" ]]; then
99105
export WINDOWS_WORKER_MACHINE_COUNT="${WINDOWS_WORKER_MACHINE_COUNT:-2}"
100-
if [[ -n "${K8S_FEATURE_GATES:-}" ]]; then
101-
export K8S_FEATURE_GATES="${K8S_FEATURE_GATES:-},WindowsHostProcessContainers=true"
102-
else
103-
export K8S_FEATURE_GATES="WindowsHostProcessContainers=true"
104-
fi
105106
fi
106107
}
107108

0 commit comments

Comments
 (0)