Skip to content

Commit dddbac9

Browse files
authored
Merge pull request #3221 from CecileRobertMichon/oot-ipv6
Switch ipv6 template to external cloud-provider
2 parents 82514e3 + dd87b4a commit dddbac9

File tree

6 files changed

+12
-52
lines changed

6 files changed

+12
-52
lines changed

Tiltfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def deploy_worker_templates(template, substitutions):
371371
else:
372372
calico_values = "./templates/addons/calico/values.yaml"
373373
flavor_cmd += "; " + helm_cmd + " repo add projectcalico https://docs.tigera.io/calico/charts; " + helm_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig install calico projectcalico/tigera-operator -f " + calico_values + " --namespace tigera-operator --create-namespace"
374-
if "intree-cloud-provider" not in flavor_name and "ipv6" not in flavor_name: # TODO: remove ipv6 once https://github.com/kubernetes-sigs/cloud-provider-azure/issues/3401 is fixed.
374+
if "intree-cloud-provider" not in flavor_name:
375375
flavor_cmd += "; " + helm_cmd + " --kubeconfig ./${CLUSTER_NAME}.kubeconfig install --repo https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/helm/repo cloud-provider-azure --generate-name --set infra.clusterName=${CLUSTER_NAME}"
376376
local_resource(
377377
name = flavor_name,

templates/cluster-template-ipv6.yaml

Lines changed: 5 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/flavors/ipv6/kustomization.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ resources:
66

77
patchesStrategicMerge:
88
- ../../azure-cluster-identity/azurecluster-identity-ref.yaml
9-
- ../../test/ci/prow-intree-cloud-provider/patches/intree-cp.yaml # TODO: enable CCM for ipv6, see https://github.com/kubernetes-sigs/cloud-provider-azure/issues/3401.
10-
- ../../test/ci/prow-intree-cloud-provider/patches/intree-md-0.yaml # TODO: enable CCM for ipv6, see https://github.com/kubernetes-sigs/cloud-provider-azure/issues/3401.
119
- patches/ipv6.yaml
1210
- patches/kubeadm-controlplane.yaml
1311
- patches/controlplane-azuremachinetemplate.yaml

templates/flavors/ipv6/machine-deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ spec:
5555
name: '{{ ds.meta_data["local_hostname"] }}'
5656
kubeletExtraArgs:
5757
azure-container-registry-config: /etc/kubernetes/azure.json
58-
node-ip: "::"
58+
cloud-provider: external
5959
cluster-dns: "[fd00::10]"
6060
clusterConfiguration:
6161
apiServer:

templates/flavors/ipv6/patches/kubeadm-controlplane.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ spec:
1313
nodeRegistration:
1414
name: '{{ ds.meta_data["local_hostname"] }}'
1515
kubeletExtraArgs:
16-
node-ip: "::"
1716
cluster-dns: "fd00::10"
1817
localAPIEndpoint:
1918
advertiseAddress: "::"
@@ -22,7 +21,6 @@ spec:
2221
nodeRegistration:
2322
name: '{{ ds.meta_data["local_hostname"] }}'
2423
kubeletExtraArgs:
25-
node-ip: "::"
2624
cluster-dns: "fd00::10"
2725
controlPlane:
2826
localAPIEndpoint:

templates/test/ci/cluster-template-prow-ipv6.yaml

Lines changed: 5 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)