Merge pull request #4800 from willie-yao/fleet-fixes

Don't allow fleetsMembers to have capital letters. Default spec.group.

Author: k8s-ci-robot

api/v1beta1/azuremanagedcontrolplane_default.go

@@ -101,8 +101,13 @@ func (m *AzureManagedControlPlane) setDefaultSubnet() {
 // setDefaultFleetsMember sets the default FleetsMember for an AzureManagedControlPlane.
 func setDefaultFleetsMember(fleetsMember *FleetsMember, labels map[string]string) *FleetsMember {
 	result := fleetsMember.DeepCopy()
-	if clusterName, ok := labels[clusterv1.ClusterNameLabel]; ok && fleetsMember != nil && fleetsMember.Name == "" {
-		result.Name = clusterName
+	if fleetsMember != nil {
+		if clusterName, ok := labels[clusterv1.ClusterNameLabel]; ok && fleetsMember.Name == "" {
+			result.Name = clusterName
+		}
+		if fleetsMember.Group == "" {
+			result.Group = "default"
+		}
 	}
 	return result
 }

api/v1beta1/azuremanagedcontrolplane_webhook.go

@@ -220,7 +220,7 @@ func (mw *azureManagedControlPlaneWebhook) ValidateUpdate(ctx context.Context, o
 		allErrs = append(allErrs, errs...)
 	}
 
-	if errs := m.validateFleetsMember(old); len(errs) > 0 {
+	if errs := m.validateFleetsMemberUpdate(old); len(errs) > 0 {
 		allErrs = append(allErrs, errs...)
 	}
 
@@ -292,6 +292,8 @@ func (m *AzureManagedControlPlane) Validate(cli client.Client) error {
 
 	allErrs = append(allErrs, validateAMCPVirtualNetwork(m.Spec.VirtualNetwork, field.NewPath("spec").Child("VirtualNetwork"))...)
 
+	allErrs = append(allErrs, validateFleetsMember(m.Spec.FleetsMember, field.NewPath("spec").Child("FleetsMember"))...)
+
 	return allErrs.ToAggregate()
 }
 
@@ -463,6 +465,25 @@ func validateAMCPVirtualNetwork(virtualNetwork ManagedControlPlaneVirtualNetwork
 	return allErrs
 }
 
+func validateFleetsMember(fleetsMember *FleetsMember, fldPath *field.Path) field.ErrorList {
+	var allErrs field.ErrorList
+
+	if fleetsMember != nil && fleetsMember.Name != "" {
+		match, _ := regexp.MatchString(`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`, fleetsMember.Name)
+		if !match {
+			allErrs = append(allErrs,
+				field.Invalid(
+					fldPath.Child("Name"),
+					fleetsMember.Name,
+					"Name must match ^[a-z0-9]([-a-z0-9]*[a-z0-9])?$",
+				),
+			)
+		}
+	}
+
+	return allErrs
+}
+
 // validateAPIServerAccessProfile validates an APIServerAccessProfile.
 func validateAPIServerAccessProfile(apiServerAccessProfile *APIServerAccessProfile, fldPath *field.Path) field.ErrorList {
 	var allErrs field.ErrorList
@@ -882,8 +903,8 @@ func (m *AzureManagedControlPlane) validateOIDCIssuerProfileUpdate(old *AzureMan
 	return allErrs
 }
 
-// validateFleetsMember validates a FleetsMember.
-func (m *AzureManagedControlPlane) validateFleetsMember(old *AzureManagedControlPlane) field.ErrorList {
+// validateFleetsMemberUpdate validates a FleetsMember.
+func (m *AzureManagedControlPlane) validateFleetsMemberUpdate(old *AzureManagedControlPlane) field.ErrorList {
 	var allErrs field.ErrorList
 
 	if old.Spec.FleetsMember == nil || m.Spec.FleetsMember == nil {

api/v1beta1/azuremanagedcontrolplane_webhook_test.go

@@ -1354,6 +1354,36 @@ func TestValidatingWebhook(t *testing.T) {
 			},
 			expectErr: true,
 		},
+		{
+			name: "Testing valid FleetsMember",
+			amcp: AzureManagedControlPlane{
+				ObjectMeta: getAMCPMetaData(),
+				Spec: AzureManagedControlPlaneSpec{
+					FleetsMember: &FleetsMember{
+						Name: "fleetmember1",
+					},
+					AzureManagedControlPlaneClassSpec: AzureManagedControlPlaneClassSpec{
+						Version: "v1.17.8",
+					},
+				},
+			},
+			expectErr: false,
+		},
+		{
+			name: "Testing invalid FleetsMember: Fleets member name cannot contain capital letters",
+			amcp: AzureManagedControlPlane{
+				ObjectMeta: getAMCPMetaData(),
+				Spec: AzureManagedControlPlaneSpec{
+					FleetsMember: &FleetsMember{
+						Name: "FleetMember1",
+					},
+					AzureManagedControlPlaneClassSpec: AzureManagedControlPlaneClassSpec{
+						Version: "v1.17.8",
+					},
+				},
+			},
+			expectErr: true,
+		},
 	}
 
 	for _, tt := range tests {