Merge pull request #5277 from nojnhuh/sp-cert

fix ServicePrincipalCertificate not reading from Secret

Author: k8s-ci-robot

azure/scope/identity.go

@@ -212,6 +212,8 @@ func (p *AzureCredentialsProvider) hasClientSecret() bool {
 	switch p.Identity.Spec.Type {
 	case infrav1.ServicePrincipal, infrav1.ManualServicePrincipal:
 		return true
+	case infrav1.ServicePrincipalCertificate:
+		return p.Identity.Spec.CertPath == ""
 	default:
 		return false
 	}

azure/scope/identity_test.go

@@ -166,6 +166,16 @@ func TestHasClientSecret(t *testing.T) {
 					Type: infrav1.ServicePrincipalCertificate,
 				},
 			},
+			want: true,
+		},
+		{
+			name: "service principal with certificate path",
+			identity: &infrav1.AzureClusterIdentity{
+				Spec: infrav1.AzureClusterIdentitySpec{
+					Type:     infrav1.ServicePrincipalCertificate,
+					CertPath: "something",
+				},
+			},
 			want: false,
 		},
 		{