-
Notifications
You must be signed in to change notification settings - Fork 460
add user-assigned identity to worker nodes for CI version templates #4918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @jackfrancis @mboersma |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4918 +/- ##
==========================================
+ Coverage 62.18% 62.19% +0.01%
==========================================
Files 201 201
Lines 16878 16878
==========================================
+ Hits 10495 10497 +2
+ Misses 5593 5591 -2
Partials 790 790 ☔ View full report in Codecov by Sentry. |
|
/test ? |
|
@nojnhuh: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 10c34e43288fe4c1662ee65dfafd71051c7275b2
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
In the wake of #4765 I noticed the Azure File/Azure Disk CSI driver tests were failing and it looks like because cloud-provider auth isn't working: https://testgrid.k8s.io/provider-azure-master-signal. This PR adds the user-assigned identity to worker nodes for the templates used by those tests so the CSI drivers which invoke cloud-provider from worker nodes can work as expected.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: