Skip to content

fix RBAC upgrade #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix RBAC upgrade #4956

merged 1 commit into from
Jul 1, 2024
+7 −7

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 1, 2024

What type of PR is this?
/kind failing-test

What this PR does / why we need it: The tests that upgrade CAPZ don't agree with #4933 because it changed the ClusterRole referred to by the ClusterRoleBinding for the CAPZ controller manager which Kubernetes doesn't allow. This change does some light name swizzling to keep the names the same from previous releases while keeping the new aggregated role functionality.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

/test pull-cluster-api-provider-azure-apiversion-upgrade

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2024
@jackfrancis
Copy link
Contributor

jackfrancis commented Jul 1, 2024

good catch!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 1, 2024

LGTM label has been added.

Git tree hash: f7c70a68ddc1c4c95770806011901a1a4bb022b1

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

/hold for upgrade test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@codecov
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.22%. Comparing base (c304ddc) to head (ac666fe).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4956   +/-   ##
=======================================
  Coverage   62.22%   62.22%           
=======================================
  Files         201      201           
  Lines       16886    16886           
=======================================
  Hits        10508    10508           
  Misses       5585     5585           
  Partials      793      793

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

/test pull-cluster-api-provider-azure-e2e-aks

FYI @jackfrancis I'm not sure I've seen this kind of error before in the workload ID setup stuff: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/4956/pull-cluster-api-provider-azure-e2e-aks/1807834346007040000

@jackfrancis
Copy link
Contributor

jackfrancis commented Jul 1, 2024

/test pull-cluster-api-provider-azure-e2e-aks

FYI @jackfrancis I'm not sure I've seen this kind of error before in the workload ID setup stuff: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/4956/pull-cluster-api-provider-azure-e2e-aks/1807834346007040000

My best guess would be a flake in the az storage blob service-properties update operation. Because we're not retrying any of these commands, I wouldn't be surprised if we see these flakes (until we add retries, that is).

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

#4264
/test pull-cluster-api-provider-azure-e2e

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

Upgrade test is green, others look like flakes.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

/test pull-cluster-api-provider-azure-e2e

1 similar comment
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 1, 2024 •
edited
Loading

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-with-wi-optional ac666fe link false /test pull-cluster-api-provider-azure-e2e-with-wi-optional

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 1, 2024

Cannot create more than 20 public IP addresses for this subscription in this region.

This message doesn't make sense given canadacentral currently has 5 IPs allocated and southcentralus currently has 35. I'll try one more time to see if I get lucky and look into this more tomorrow.

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot merged commit 39ee175 into kubernetes-sigs:main Jul 1, 2024
@nojnhuh nojnhuh deleted the fix-rbac-upgrade branch July 1, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marosset marosset Awaiting requested review from marosset

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@jackfrancis jackfrancis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

CAPZ Planning
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nojnhuh @jackfrancis @k8s-ci-robot