Skip to content

Revert "Update Tiltfile to use env variable to check aks cluster is being used" #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

Revert "Update Tiltfile to use env variable to check aks cluster is being used" #5353

merged 1 commit into from
Jan 3, 2025

Conversation

@nawazkh
Copy link
Member

@nawazkh nawazkh commented Jan 3, 2025 •
edited
Loading

Reverts #5306

Reason to revert: #5306 (comment)

Reopens: #5289

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 3, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Jan 3, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@nawazkh: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (6bce7f8) to head (c897f28).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5353   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files         272      272           
  Lines       29401    29401           
=======================================
  Hits        15417    15417           
  Misses      13178    13178           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mboersma
mboersma approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Mea culpa!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b802253d5e3da7c78218f139eeeb85fa0fc07b9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00dfab1 into main Jan 3, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2025
@nawazkh nawazkh deleted the revert-5306-issue5289 branch January 3, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@marosset marosset Awaiting requested review from marosset

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

4 participants

@nawazkh @k8s-ci-robot @mboersma