Skip to content

replace deprecated markdown link check action with tcort/github-actio… #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

replace deprecated markdown link check action with tcort/github-actio… #5823

merged 1 commit into from
Aug 18, 2025

Conversation

@3mbe
Copy link
Contributor

@3mbe 3mbe commented Aug 17, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
gaurav-nelson/github-action-markdown-link-check was deprecated and is no longer maintained. The recommended maintained fork is tcort/github-action-markdown-link-check. This PR updates our docs lint workflow to use the maintained fork and pins it to an exact commit SHA for supply-chain safety.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5598

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 17, 2025
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 17, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 17, 2025 •
edited
Loading

CLA Signed

  • ✅login: 3mbe / name: Marcos Blount / (0a7c1eb)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2025

Welcome @3mbe!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2025

Hi @3mbe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2025
@mboersma
Copy link
Contributor

mboersma commented Aug 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.94%. Comparing base (e859273) to head (0a7c1eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5823   +/-   ##
=======================================
  Coverage   46.93%   46.94%           
=======================================
  Files         279      279           
  Lines       29687    29687           
=======================================
+ Hits        13934    13936    +2     
+ Misses      14940    14938    -2     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.94%. Comparing base (e859273) to head (0a7c1eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5823   +/-   ##
=======================================
  Coverage   46.93%   46.94%           
=======================================
  Files         279      279           
  Lines       29687    29687           
=======================================
+ Hits        13934    13936    +2     
+ Misses      14940    14938    -2     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mboersma
mboersma approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 18, 2025

LGTM label has been added.

Git tree hash: bed7c2e0e9d2a44b616b6d793b7a43856ca96808

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0a5f229 into kubernetes-sigs:main Aug 18, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 18, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Aug 18, 2025
@3mbe 3mbe deleted the github-actin-lint-check branch August 18, 2025 18:09
@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 28, 2025

/milestone v1.22

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.22 Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

4 participants

@3mbe @k8s-ci-robot @mboersma @nojnhuh