[release-1.21] Get GO_VERSION from toolchain statment #5879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.21 #5879 +/- ##
================================================
- Coverage 46.94% 46.93% -0.01%
================================================
Files 279 279
Lines 29687 29687
================================================
- Hits 13936 13934 -2
- Misses 14938 14940 +2
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 58fd394a011b28e1c8eed7ac6903ca00048dcf21
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Manual cherry-pick of part of #5865
Changes
make go-versionto use thetoolchainstatement ingo.mod. Thegostatement generally represents a "base" version and lags behindtoolchain, which is the version actually used.The discrepency caused the weekly security scan job to report false positives based on security issues in the base version of Go, which isn't actually being used.
Which issue(s) this PR fixes:
Fixes security scan failure
Special notes for your reviewer:
TODOs:
Release note: