Refactoring controller to check vm state before adding vm to lb rule (#6)

* Refactoring controller to check vm state before adding vm to lb rule

* Adding PR template

Author: maxdrib

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,10 @@
+*Issue #, if available:*
+
+*Description of changes:*
+
+*Testing performed:*
+
+
+By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
+
+<!-- If this is a security issue, please do not discuss on GitHub. Please report any suspected or confirmed security issues to AWS Security https://aws.amazon.com/security/vulnerability-reporting/ -->

controllers/cloudstackmachine_controller.go

@@ -179,14 +179,6 @@ func (r *CloudStackMachineReconciler) reconcile(
 		return ctrl.Result{}, err
 	}
 
-	if util.IsControlPlaneMachine(machine) && csCluster.Status.NetworkType != cloud.NetworkTypeShared {
-		log.Info("Assigning VM to load balancer rule.")
-		err := r.CS.AssignVMToLoadBalancerRule(csCluster, *csMachine.Spec.InstanceID)
-		if err != nil {
-			return ctrl.Result{}, err
-		}
-	}
-
 	if csMachine.Status.InstanceState == "Running" {
 		log.Info("Machine instance is Running...")
 		csMachine.Status.Ready = true
@@ -201,6 +193,14 @@ func (r *CloudStackMachineReconciler) reconcile(
 		return ctrl.Result{RequeueAfter: RequeueTimeout}, nil
 	}
 
+	if util.IsControlPlaneMachine(machine) && csCluster.Status.NetworkType != cloud.NetworkTypeShared {
+		log.Info("Assigning VM to load balancer rule.")
+		err := r.CS.AssignVMToLoadBalancerRule(csCluster, *csMachine.Spec.InstanceID)
+		if err != nil {
+			return ctrl.Result{}, err
+		}
+	}
+
 	return ctrl.Result{}, nil
 }