Make the error messages lower cases before comparing them

Author: wongni

controllers/utils/utils.go

@@ -93,15 +93,15 @@ func IsOwnerDeleted(ctx context.Context, client clientPkg.Client, capiMachine *c
 		// As such, need to check the deletion timestamp thereof.
 		if cp, err := getKubeadmControlPlaneFromCAPIMachine(ctx, client, capiMachine); cp != nil && cp.DeletionTimestamp == nil {
 			return false, nil
-		} else if err != nil && !strings.Contains(err.Error(), "not found") {
+		} else if err != nil && !strings.Contains(strings.ToLower(err.Error()), "not found") {
 			return false, err
 		}
 	} else {
 		// The machineset is deleted immediately, regardless of machine ownership.
 		// It is sufficient to check for its existence.
 		if ms, err := getMachineSetFromCAPIMachine(ctx, client, capiMachine); ms != nil {
 			return false, nil
-		} else if err != nil && !strings.Contains(err.Error(), "not found") {
+		} else if err != nil && !strings.Contains(strings.ToLower(err.Error()), "not found") {
 			return false, err
 		}
 	}

pkg/cloud/client.go

@@ -69,7 +69,7 @@ func NewClient(ccPath string) (Client, error) {
 	// TODO: attempt a less clunky client liveliness check (not just listing zones).
 	c.cs = cloudstack.NewAsyncClient(cfg.APIURL, cfg.APIKey, cfg.SecretKey, cfg.VerifySSL)
 	_, err := c.cs.Zone.ListZones(c.cs.Zone.NewListZonesParams())
-	if err != nil && strings.Contains(err.Error(), "i/o timeout") {
+	if err != nil && strings.Contains(strings.ToLower(err.Error()), "i/o timeout") {
 		return c, errors.Wrap(err, "Timeout while checking CloudStack API Client connectivity.")
 	}
 	return c, errors.Wrap(err, "Error encountered while checking CloudStack API Client connectivity.")

pkg/cloud/instance.go

@@ -216,7 +216,7 @@ func (c *client) DestroyVMInstance(csMachine *infrav1.CloudStackMachine) error {
 	p := c.cs.VirtualMachine.NewDestroyVirtualMachineParams(*csMachine.Spec.InstanceID)
 	p.SetExpunge(true)
 	_, err := c.cs.VirtualMachine.DestroyVirtualMachine(p)
-	if err != nil && strings.Contains(err.Error(), "unable to find UUID for id ") {
+	if err != nil && strings.Contains(strings.ToLower(err.Error()), "unable to find UUID for id ") {
 		// VM doesn't exist.  So the desired state is in effect.  Our work is done here.
 		return nil
 	}

pkg/cloud/network.go

@@ -61,7 +61,7 @@ func (c *client) ResolveNetwork(csCluster *infrav1.CloudStackCluster) (retErr er
 func (c *client) GetOrCreateNetwork(csCluster *infrav1.CloudStackCluster) (retErr error) {
 	if retErr = c.ResolveNetwork(csCluster); retErr == nil { // Found network.
 		return nil
-	} else if !strings.Contains(retErr.Error(), "no match found") { // Some other error.
+	} else if !strings.Contains(strings.ToLower(retErr.Error()), "no match found") { // Some other error.
 		return retErr
 	} // Network not found.
 
@@ -147,7 +147,7 @@ func (c *client) AssociatePublicIPAddress(csCluster *infrav1.CloudStackCluster)
 func (c *client) OpenFirewallRules(csCluster *infrav1.CloudStackCluster) (retErr error) {
 	p := c.cs.Firewall.NewCreateEgressFirewallRuleParams(csCluster.Status.NetworkID, NetworkProtocolTCP)
 	_, retErr = c.cs.Firewall.CreateEgressFirewallRule(p)
-	if retErr != nil && strings.Contains(retErr.Error(), "there is already") { // Already a firewall rule here.
+	if retErr != nil && strings.Contains(strings.ToLower(retErr.Error()), "there is already") { // Already a firewall rule here.
 		retErr = nil
 	}
 	return retErr
@@ -175,7 +175,7 @@ func (c *client) ResolveLoadBalancerRuleDetails(csCluster *infrav1.CloudStackClu
 func (c *client) GetOrCreateLoadBalancerRule(csCluster *infrav1.CloudStackCluster) (retErr error) {
 	// Check if rule exists.
 	if err := c.ResolveLoadBalancerRuleDetails(csCluster); err == nil ||
-		!strings.Contains(err.Error(), "no load balancer rule found") {
+		!strings.Contains(strings.ToLower(err.Error()), "no load balancer rule found") {
 		return err
 	}