Skip to content

Commit 43c84d3

Browse files
authored
Merge pull request #27 from aws/fix-base64
make base64 encode works for both macos and linux
2 parents 0112105 + dd2bdde commit 43c84d3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ pkg/mocks/mock%.go: $(shell find ./pkg/cloud -type f -name "*test*" -prune -o -p
178178

179179
.PHONY: tilt-up
180180
tilt-up: cluster-api kind-cluster cluster-api/tilt-settings.json manifests cloud-config # Setup and run tilt for development.
181-
export CLOUDSTACK_B64ENCODED_SECRET=$$(base64 -i cloud-config) && cd cluster-api && tilt up
181+
export CLOUDSTACK_B64ENCODED_SECRET=$(base64 -w0 -i cloud-config 2>/dev/null || base64 -b 0 -i cloud-config) && cd cluster-api && tilt up
182182

183183
.PHONY: kind-cluster
184184
kind-cluster: cluster-api # Create a kind cluster with a local Docker repository.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Another container networking choice is to use [kindnet](https://github.com/aojea
8080
2. Run the following command to save the above cloudstack connection info into an environment variable, to be used by `./config/default/credentials.yaml` and ultimately the generated `infrastructure-components.yaml`, where it gets passed to CAPC:
8181
8282
```
83-
export CLOUDSTACK_B64ENCODED_SECRET=$(base64 -i cloud-config)
83+
export CLOUDSTACK_B64ENCODED_SECRET=$(base64 -w0 -i cloud-config 2>/dev/null || base64 -b 0 -i cloud-config)
8484
```
8585
6. Set the IMG environment variable so that the Makefile knows where to push docker image (if building your own)
8686
1. `export IMG=localhost:5000/cluster-api-provider-capc`
@@ -144,7 +144,7 @@ Another container networking choice is to use [kindnet](https://github.com/aojea
144144
145145
3. Generate the CAPC cluster spec yaml file
146146
```
147-
clusterctl generate cluster \
147+
clusterctl generate cluster capc-cluster \
148148
--from ~/.cluster-api/overrides/infrastructure-cloudstack/<VERSION>/cluster-template.yaml \
149149
> capc-cluster-spec.yaml
150150
@@ -173,7 +173,7 @@ Another container networking choice is to use [kindnet](https://github.com/aojea
173173
2. Run `KUBECONFIG=capc-cluster.kubeconfig cilium status` to confirm cilium status
174174
175175
8. Verify the K8s cluster is fully up
176-
1. Run `KUBECONFIG=capc-cluster.kubeconfig get nodes`, and observe the following output
176+
1. Run `KUBECONFIG=capc-cluster.kubeconfig kubectl get nodes`, and observe the following output
177177
```
178178
NAME STATUS ROLES AGE VERSION
179179
capc-cluster-control-plane-xsnxt Ready control-plane,master 2m56s v1.20.10

0 commit comments

Comments
 (0)