Adding validation for cluster webhook to ensure there's no change in CP endpoint after the cluster is running (#10)

Author: maxdrib

api/v1alpha3/cloudstackcluster_webhook.go

@@ -94,6 +94,8 @@ func (r *CloudStackCluster) ValidateUpdate(old runtime.Object) error {
 	// No spec fields may be changed
 	errorList = webhook_utilities.EnsureStringFieldsAreEqual(spec.Zone, oldSpec.Zone, "zone", errorList)
 	errorList = webhook_utilities.EnsureStringFieldsAreEqual(spec.Network, oldSpec.Network, "network", errorList)
+	errorList = webhook_utilities.EnsureStringFieldsAreEqual(spec.ControlPlaneEndpoint.Host, oldSpec.ControlPlaneEndpoint.Host, "controlplaneendpointhost", errorList)
+	errorList = webhook_utilities.EnsureStringFieldsAreEqual(string(spec.ControlPlaneEndpoint.Port), string(oldSpec.ControlPlaneEndpoint.Port), "controlplaneendpointport", errorList)
 	if spec.IdentityRef != nil && oldSpec.IdentityRef != nil {
 		errorList = webhook_utilities.EnsureStringFieldsAreEqual(spec.IdentityRef.Kind, oldSpec.IdentityRef.Kind, "identityRef.Kind", errorList)
 		errorList = webhook_utilities.EnsureStringFieldsAreEqual(spec.IdentityRef.Name, oldSpec.IdentityRef.Name, "identityRef.Name", errorList)

api/v1alpha3/cloudstackcluster_webhook_test.go

@@ -155,6 +155,14 @@ var _ = Describe("CloudStackCluster webhooks", func() {
 				cloudStackClusterUpdate.Spec.Network = "Network2"
 				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "network"))
 
+				cloudStackCluster.DeepCopyInto(cloudStackClusterUpdate)
+				cloudStackClusterUpdate.Spec.ControlPlaneEndpoint.Host = "1.1.1.1"
+				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "controlplaneendpointhost"))
+
+				cloudStackCluster.DeepCopyInto(cloudStackClusterUpdate)
+				cloudStackClusterUpdate.Spec.ControlPlaneEndpoint.Port = 1234
+				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "controlplaneendpointport"))
+
 				cloudStackCluster.DeepCopyInto(cloudStackClusterUpdate)
 				cloudStackClusterUpdate.Spec.IdentityRef.Kind = "ConfigMap"
 				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "identityRef\\.Kind"))