Skip to content

Commit 77755d2

Browse files
more changes
1 parent edf40fb commit 77755d2

File tree

4 files changed

+39
-14
lines changed

4 files changed

+39
-14
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ generate-conversion: $(CONVERSION_GEN) ## Generate code to convert api/v1beta1 a
176176

177177
MANAGER_BIN_INPUTS=$(shell find ./controllers ./api ./pkg -name "*mock*" -prune -o -name "*test*" -prune -o -type f -print) main.go go.mod go.sum
178178
.PHONY: build
179-
build: binaries generate-deepcopy lint generate-manifests release-manifests ## Build manager binary.
179+
build: binaries generate-deepcopy generate-manifests release-manifests ## Build manager binary.
180180
$(BIN_DIR)/manager: $(MANAGER_BIN_INPUTS)
181181
go build -o $(BIN_DIR)/manager main.go
182182

@@ -271,7 +271,7 @@ config/.flag-test.mk: $(CONTROLLER_GEN) $(MANIFEST_GEN_INPUTS_TEST)
271271

272272
.PHONY: test
273273
test: ## Run tests.
274-
test: generate-deepcopy-test generate-manifest-test generate-mocks lint $(GINKGO) $(KUBECTL) $(API_SERVER) $(ETCD)
274+
test: generate-deepcopy-test generate-manifest-test generate-mocks $(GINKGO) $(KUBECTL) $(API_SERVER) $(ETCD)
275275
@./hack/testing_ginkgo_recover_statements.sh --add # Add ginkgo.GinkgoRecover() statements to controllers.
276276
@# The following is a slightly funky way to make sure the ginkgo statements are removed regardless the test results.
277277
@$(GINKGO) --label-filter="!integ" --cover -coverprofile cover.out --covermode=atomic -v ./api/... ./controllers/... ./pkg/...; EXIT_STATUS=$$?;\

api/v1beta1/zz_generated.conversion.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/v1beta2/cloudstackmachine_conversion.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package v1beta2
1818

1919
import (
20+
machineryconversion "k8s.io/apimachinery/pkg/conversion"
2021
"sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta3"
2122
utilconversion "sigs.k8s.io/cluster-api/util/conversion"
2223
"sigs.k8s.io/controller-runtime/pkg/conversion"
@@ -51,3 +52,10 @@ func (dst *CloudStackMachine) ConvertFrom(srcRaw conversion.Hub) error { // noli
5152
err := utilconversion.MarshalData(src, dst)
5253
return err
5354
}
55+
56+
// Convert_v1beta3_CloudStackMachineSpec_To_v1beta2_CloudStackMachineSpec handles the conversion from v1beta3 to v1beta2,
57+
// ignoring the Networks field that doesn't exist in v1beta2
58+
func Convert_v1beta3_CloudStackMachineSpec_To_v1beta2_CloudStackMachineSpec(in *v1beta3.CloudStackMachineSpec, out *CloudStackMachineSpec, s machineryconversion.Scope) error { // nolint
59+
// Use the auto-generated conversion function, which will handle all fields except Networks
60+
return autoConvert_v1beta3_CloudStackMachineSpec_To_v1beta2_CloudStackMachineSpec(in, out, s)
61+
}

api/v1beta2/zz_generated.conversion.go

Lines changed: 28 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)