Fix the issue where v1beta1 unit tests were not running

Author: wongni

api/v1beta1/conversion_test.go

@@ -19,7 +19,10 @@ package v1beta1_test
 import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
-	infrav1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta1"
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	v1beta1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta1"
+	v1beta2 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta2"
 	capiv1 "sigs.k8s.io/cluster-api/api/v1beta1"
 )
 
@@ -28,19 +31,17 @@ var _ = Describe("Conversion", func() {
 	})
 
 	Context("GetFailureDomains function", func() {
-		It("Return the correct value when the last state update time is known", func() {
-			csCluster := &infrav1.CloudStackCluster{
-				Spec: infrav1.CloudStackClusterSpec{
-					Zones: []infrav1.Zone{
-						{
-							Name: "zone-name1",
-							Network: infrav1.Network{
-								Name: "network1",
-							},
-						},
+		It("Converts v1beta1 cluster spec to v1beta2 failure domains", func() {
+			csCluster := &v1beta1.CloudStackCluster{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "cluster1",
+					Namespace: "namespace1",
+				},
+				Spec: v1beta1.CloudStackClusterSpec{
+					Zones: []v1beta1.Zone{
 						{
 							ID: "76472a84-d23f-4e97-b154-ee1b975ed936",
-							Network: infrav1.Network{
+							Network: v1beta1.Network{
 								Name: "network1",
 							},
 						},
@@ -52,11 +53,26 @@ var _ = Describe("Conversion", func() {
 					Account: "account1",
 					Domain:  "domain1",
 				},
-				Status: infrav1.CloudStackClusterStatus{},
+				Status: v1beta1.CloudStackClusterStatus{},
+			}
+			failureDomains, err := v1beta1.GetFailureDomains(csCluster)
+			expectedResult := []v1beta2.CloudStackFailureDomainSpec{
+				{
+					Name: "975ed936-cluster1",
+					Zone: v1beta2.CloudStackZoneSpec{
+						ID:      "76472a84-d23f-4e97-b154-ee1b975ed936",
+						Network: v1beta2.Network{Name: "network1"},
+					},
+					Account: "account1",
+					Domain:  "domain1",
+					ACSEndpoint: corev1.SecretReference{
+						Name:      "global",
+						Namespace: "namespace1",
+					},
+				},
 			}
-			failureDomains, err := infrav1.GetFailureDomains(csCluster)
 			Ω(err).ShouldNot(HaveOccurred())
-			Ω(failureDomains).Should(HaveLen(2))
+			Ω(failureDomains).Should(Equal(expectedResult))
 		})
 	})
 })

api/v1beta1/webhook_suite_test.go

@@ -0,0 +1,116 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1_test
+
+import (
+	"context"
+	"path/filepath"
+	"testing"
+	"time"
+
+	"k8s.io/client-go/rest"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	admissionv1beta1 "k8s.io/api/admission/v1beta1"
+	//+kubebuilder:scaffold:imports
+	"k8s.io/apimachinery/pkg/runtime"
+	infrav1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta1"
+	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/envtest"
+)
+
+// These tests use Ginkgo (BDD-style Go testing framework). Refer to
+// http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
+
+var k8sClient client.Client
+var testEnv *envtest.Environment
+var ctx context.Context
+var cancel context.CancelFunc
+
+func TestAPIs(t *testing.T) {
+	RegisterFailHandler(Fail)
+
+	RunSpecs(t, "Webhook Suite")
+}
+
+var _ = BeforeSuite(func() {
+	ctx, cancel = context.WithCancel(context.TODO())
+
+	By("bootstrapping test environment")
+	testEnv = &envtest.Environment{
+		CRDDirectoryPaths:     []string{filepath.Join("../../", "config", "crd", "bases")},
+		ErrorIfCRDPathMissing: false,
+		WebhookInstallOptions: envtest.WebhookInstallOptions{
+			Paths: []string{filepath.Join("../../", "config", "webhook")},
+		},
+	}
+
+	var cfg *rest.Config
+	var err error
+	done := make(chan interface{})
+	go func() {
+		defer GinkgoRecover()
+		cfg, err = testEnv.Start()
+		close(done)
+	}()
+	Eventually(done).WithTimeout(time.Minute).Should(BeClosed())
+	Expect(err).NotTo(HaveOccurred())
+	Expect(cfg).NotTo(BeNil())
+
+	scheme := runtime.NewScheme()
+	err = infrav1.AddToScheme(scheme)
+	Expect(err).NotTo(HaveOccurred())
+
+	err = admissionv1beta1.AddToScheme(scheme)
+	Expect(err).NotTo(HaveOccurred())
+
+	//+kubebuilder:scaffold:scheme
+
+	k8sClient, err = client.New(cfg, client.Options{Scheme: scheme})
+	Expect(err).NotTo(HaveOccurred())
+	Expect(k8sClient).NotTo(BeNil())
+
+	// start webhook server using Manager
+	webhookInstallOptions := &testEnv.WebhookInstallOptions
+	mgr, err := ctrl.NewManager(cfg, ctrl.Options{
+		Scheme:             scheme,
+		Host:               webhookInstallOptions.LocalServingHost,
+		Port:               webhookInstallOptions.LocalServingPort,
+		CertDir:            webhookInstallOptions.LocalServingCertDir,
+		LeaderElection:     false,
+		MetricsBindAddress: "0",
+	})
+	Expect(err).NotTo(HaveOccurred())
+
+	//+kubebuilder:scaffold:webhook
+
+	go func() {
+		defer GinkgoRecover()
+		err = mgr.Start(ctrl.SetupSignalHandler())
+		Expect(err).NotTo(HaveOccurred())
+	}()
+})
+
+var _ = AfterSuite(func() {
+	cancel()
+	By("tearing down the test environment")
+	err := testEnv.Stop()
+	Expect(err).NotTo(HaveOccurred())
+})