small fix on cleanup sequence

wanyufe · wanyufe · commit 8c8be255e3d2 · 2022-10-07T21:13:55.000-04:00
diff --git a/controllers/controllers_suite_test.go b/controllers/controllers_suite_test.go
@@ -242,8 +242,8 @@ func SetupTestEnvironment() {
 
 	DeferCleanup(func() {
 		// Cancelling the context shuts down any outstanding requests and the test environment.
-		Ω(testEnv.Stop()).Should(Succeed())
 		cancel()
+		Ω(testEnv.Stop()).Should(Succeed())
 		k8sManager = nil
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -242,8 +242,8 @@ func SetupTestEnvironment() {`
`242`	`242`
`243`	`243`	`DeferCleanup(func() {`
`244`	`244`	`// Cancelling the context shuts down any outstanding requests and the test environment.`
`245`		`- Ω(testEnv.Stop()).Should(Succeed())`
`246`	`245`	`cancel()`
	`246`	`+ Ω(testEnv.Stop()).Should(Succeed())`
`247`	`247`	`k8sManager = nil`
`248`	`248`	`})`
`249`	`249`	`}`