Add multiple nics support to nodes

Author: harikrishna-patnala

api/v1beta3/cloudstackmachine_types.go

@@ -71,6 +71,14 @@ type CloudStackMachineSpec struct {
 	// +optional
 	Affinity string `json:"affinity,omitempty"`
 
+	// The primary network interface (overrides zone.network)
+	// +optional
+	Network *NetworkSpec `json:"network,omitempty"`
+
+	// Additional networks (attached as secondary NICs)
+	// +optional
+	ExtraNetworks []NetworkSpec `json:"extraNetworks,omitempty"`
+
 	// Mutually exclusive parameter with AffinityGroupIDs.
 	// Is a reference to a CloudStack affinity group CRD.
 	// +optional
@@ -91,6 +99,12 @@ type CloudStackMachineSpec struct {
 	UncompressedUserData *bool `json:"uncompressedUserData,omitempty"`
 }
 
+type NetworkSpec struct {
+	Name string `json:"name"`
+	// +optional
+	IP string `json:"ip,omitempty"`
+}
+
 func (c *CloudStackMachine) CompressUserdata() bool {
 	return c.Spec.UncompressedUserData == nil || !*c.Spec.UncompressedUserData
 }

pkg/cloud/instance.go

@@ -302,6 +302,14 @@ func (c *client) CheckLimits(
 	return nil
 }
 
+func (c *client) resolveNetworkIDByName(name string) (string, error) {
+	netDetails, count, err := c.cs.Network.GetNetworkByName(name, cloudstack.WithProject(c.user.Project.ID))
+	if err != nil || count != 1 {
+		return "", fmt.Errorf("unable to resolve network ID for %s: %v", name, err)
+	}
+	return netDetails.Id, nil
+}
+
 // DeployVM will create a VM instance,
 // and sets the infrastructure machine spec and status accordingly.
 func (c *client) DeployVM(
@@ -322,7 +330,45 @@ func (c *client) DeployVM(
 	}
 
 	p := c.cs.VirtualMachine.NewDeployVirtualMachineParams(offering.Id, templateID, fd.Spec.Zone.ID)
-	p.SetNetworkids([]string{fd.Spec.Zone.Network.ID})
+	if csMachine.Spec.Network == nil && len(csMachine.Spec.ExtraNetworks) == 0 && fd.Spec.Zone.Network.ID != "" {
+		// No explicit NICs; fallback to single default network ID
+		p.SetNetworkids([]string{fd.Spec.Zone.Network.ID})
+	} else {
+		// Build iptonetworklist for multiple NICs
+		iptonetworklist := []map[string]string{}
+
+		// Primary NIC
+		if csMachine.Spec.Network != nil {
+			id, err := c.resolveNetworkIDByName(csMachine.Spec.Network.Name)
+			if err != nil {
+				return err
+			}
+			entry := map[string]string{"networkid": id}
+			if csMachine.Spec.Network.IP != "" {
+				entry["ip"] = csMachine.Spec.Network.IP
+			}
+			iptonetworklist = append(iptonetworklist, entry)
+		} else if fd.Spec.Zone.Network.ID != "" {
+			iptonetworklist = append(iptonetworklist, map[string]string{
+				"networkid": fd.Spec.Zone.Network.ID,
+			})
+		}
+
+		// Extra NICs
+		for _, extra := range csMachine.Spec.ExtraNetworks {
+			id, err := c.resolveNetworkIDByName(extra.Name)
+			if err != nil {
+				return err
+			}
+			entry := map[string]string{"networkid": id}
+			if extra.IP != "" {
+				entry["ip"] = extra.IP
+			}
+			iptonetworklist = append(iptonetworklist, entry)
+		}
+
+		p.SetIptonetworklist(iptonetworklist)
+	}
 	setIfNotEmpty(csMachine.Name, p.SetName)
 	setIfNotEmpty(capiMachine.Name, p.SetDisplayname)
 	setIfNotEmpty(diskOfferingID, p.SetDiskofferingid)