fix lint failures

Author: harikrishna-patnala

pkg/cloud/instance.go

@@ -313,6 +313,27 @@ func (c *client) resolveNetworkIDByName(name string) (string, error) {
 	return net.Id, nil
 }
 
+func (c *client) buildIPToNetworkList(csMachine *infrav1.CloudStackMachine) ([]map[string]string, error) {
+	ipToNetworkList := []map[string]string{}
+
+	for _, net := range csMachine.Spec.Networks {
+		networkID := net.ID
+		if networkID == "" {
+			var err error
+			networkID, err = c.resolveNetworkIDByName(net.Name)
+			if err != nil {
+				return nil, err
+			}
+		}
+		entry := map[string]string{"networkid": networkID}
+		if net.IP != "" {
+			entry["ip"] = net.IP
+		}
+		ipToNetworkList = append(ipToNetworkList, entry)
+	}
+	return ipToNetworkList, nil
+}
+
 // DeployVM will create a VM instance,
 // and sets the infrastructure machine spec and status accordingly.
 func (c *client) DeployVM(
@@ -337,24 +358,10 @@ func (c *client) DeployVM(
 	if len(csMachine.Spec.Networks) == 0 && fd.Spec.Zone.Network.ID != "" {
 		p.SetNetworkids([]string{fd.Spec.Zone.Network.ID})
 	} else {
-		ipToNetworkList := []map[string]string{}
-
-		for _, net := range csMachine.Spec.Networks {
-			networkID := net.ID
-			if networkID == "" {
-				var err error
-				networkID, err = c.resolveNetworkIDByName(net.Name)
-				if err != nil {
-					return err
-				}
-			}
-			entry := map[string]string{"networkid": networkID}
-			if net.IP != "" {
-				entry["ip"] = net.IP
-			}
-			ipToNetworkList = append(ipToNetworkList, entry)
+		ipToNetworkList, err := c.buildIPToNetworkList(csMachine)
+		if err != nil {
+			return err
 		}
-
 		p.SetIptonetworklist(ipToNetworkList)
 	}