Fix a bug in ZoneStatusMap.GetByName

wongni · wongni · commit df21c5a28b4e · 2022-03-15T18:41:40.000-05:00
diff --git a/api/v1beta1/cloudstackcluster_types.go b/api/v1beta1/cloudstackcluster_types.go
@@ -67,8 +67,8 @@ func (zones ZoneStatusMap) GetOne() *Zone {
 // GetByName fetches a zone by name if present in the map of zone statuses.
 // Needed as there's no short way to do this.
 func (zones ZoneStatusMap) GetByName(name string) *Zone {
-	for zoneName, zone := range zones {
-		if zoneName == name {
+	for _, zone := range zones {
+		if zone.Name == name {
 			return &zone
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,8 @@ func (zones ZoneStatusMap) GetOne() *Zone {`
`67`	`67`	`// GetByName fetches a zone by name if present in the map of zone statuses.`
`68`	`68`	`// Needed as there's no short way to do this.`
`69`	`69`	`func (zones ZoneStatusMap) GetByName(name string) *Zone {`
`70`		`- for zoneName, zone := range zones {`
`71`		`- if zoneName == name {`
	`70`	`+ for _, zone := range zones {`
	`71`	`+ if zone.Name == name {`
`72`	`72`	`return &zone`
`73`	`73`	`}`
`74`	`74`	`}`