Merge branch 'main' into feature/network-tags

Author: mrog

api/v1beta1/cloudstackcluster_webhook_test.go

@@ -26,25 +26,35 @@ import (
 )
 
 var _ = Describe("CloudStackCluster webhooks", func() {
+	const (
+		apiVersion         = "infrastructure.cluster.x-k8s.io/v1beta1"
+		clusterKind        = "CloudStackCluster"
+		clusterName        = "test-cluster"
+		clusterNamespace   = "default"
+		identitySecretName = "IdentitySecret"
+		zone               = "Zone"
+		network            = "Network"
+	)
+
 	Context("When creating a CloudStackCluster with all validated attributes", func() {
 		It("Should succeed", func() {
 			ctx := context.Background()
 			cloudStackCluster := &CloudStackCluster{
 				TypeMeta: metav1.TypeMeta{
-					APIVersion: "infrastructure.cluster.x-k8s.io/v1beta1",
-					Kind:       "CloudStackCluster",
+					APIVersion: apiVersion,
+					Kind:       clusterKind,
 				},
 				ObjectMeta: metav1.ObjectMeta{
-					Name:      "test-cluster",
-					Namespace: "default",
+					Name:      clusterName,
+					Namespace: clusterNamespace,
 				},
 				Spec: CloudStackClusterSpec{
 					IdentityRef: &CloudStackIdentityReference{
 						Kind: defaultIdentityRefKind,
-						Name: "IdentitySecret",
+						Name: identitySecretName,
 					},
-					Zone:    "Zone",
-					Network: "Network",
+					Zone:    zone,
+					Network: network,
 				},
 			}
 			Expect(k8sClient.Create(ctx, cloudStackCluster)).Should(Succeed())
@@ -56,19 +66,19 @@ var _ = Describe("CloudStackCluster webhooks", func() {
 			ctx := context.Background()
 			cloudStackCluster := &CloudStackCluster{
 				TypeMeta: metav1.TypeMeta{
-					APIVersion: "infrastructure.cluster.x-k8s.io/v1beta1",
-					Kind:       "CloudStackCluster",
+					APIVersion: apiVersion,
+					Kind:       clusterKind,
 				},
 				ObjectMeta: metav1.ObjectMeta{
-					Name:      "test-cluster",
-					Namespace: "default",
+					Name:      clusterName,
+					Namespace: clusterNamespace,
 				},
 				Spec: CloudStackClusterSpec{
 					IdentityRef: &CloudStackIdentityReference{
 						Kind: defaultIdentityRefKind,
-						Name: "IdentitySecret",
+						Name: identitySecretName,
 					},
-					Zone: "Zone",
+					Zone: zone,
 				},
 			}
 			Expect(k8sClient.Create(ctx, cloudStackCluster).Error()).Should(MatchRegexp("admission webhook.*denied the request.*Required value\\: Network"))
@@ -80,44 +90,49 @@ var _ = Describe("CloudStackCluster webhooks", func() {
 			ctx := context.Background()
 			cloudStackCluster := &CloudStackCluster{
 				TypeMeta: metav1.TypeMeta{
-					APIVersion: "infrastructure.cluster.x-k8s.io/v1beta1",
-					Kind:       "CloudStackCluster",
+					APIVersion: apiVersion,
+					Kind:       clusterKind,
 				},
 				ObjectMeta: metav1.ObjectMeta{
-					Name:      "test-cluster",
-					Namespace: "default",
+					Name:      clusterName,
+					Namespace: clusterNamespace,
 				},
 				Spec: CloudStackClusterSpec{
 					IdentityRef: &CloudStackIdentityReference{
 						Kind: defaultIdentityRefKind,
-						Name: "IdentitySecret",
+						Name: identitySecretName,
 					},
-					Network: "Network",
+					Network: network,
 				},
 			}
 			Expect(k8sClient.Create(ctx, cloudStackCluster).Error()).Should(MatchRegexp("admission webhook.*denied the request.*Required value\\: Zone"))
 		})
 	})
 
 	Context("When creating a CloudStackCluster with the wrong kind of IdentityReference", func() {
+		const (
+			configMapKind = "ConfigMap"
+			configMapName = "IdentityConfigMap"
+		)
+
 		It("Should be rejected by the validating webhooks", func() {
 			ctx := context.Background()
 			cloudStackCluster := &CloudStackCluster{
 				TypeMeta: metav1.TypeMeta{
-					APIVersion: "infrastructure.cluster.x-k8s.io/v1beta1",
-					Kind:       "CloudStackCluster",
+					APIVersion: apiVersion,
+					Kind:       clusterKind,
 				},
 				ObjectMeta: metav1.ObjectMeta{
-					Name:      "test-cluster",
-					Namespace: "default",
+					Name:      clusterName,
+					Namespace: clusterNamespace,
 				},
 				Spec: CloudStackClusterSpec{
 					IdentityRef: &CloudStackIdentityReference{
-						Kind: "ConfigMap",
-						Name: "IdentityConfigMap",
+						Kind: configMapKind,
+						Name: configMapName,
 					},
-					Zone:    "Zone",
-					Network: "Network",
+					Zone:    zone,
+					Network: network,
 				},
 			}
 			Expect(k8sClient.Create(ctx, cloudStackCluster).Error()).Should(MatchRegexp("admission webhook.*denied the request.*Forbidden\\: must be a Secret"))
@@ -139,15 +154,15 @@ var _ = Describe("CloudStackCluster webhooks", func() {
 					},
 					ObjectMeta: metav1.ObjectMeta{
 						Name:      "test-cluster2",
-						Namespace: "default",
+						Namespace: clusterNamespace,
 					},
 					Spec: CloudStackClusterSpec{
 						IdentityRef: &CloudStackIdentityReference{
 							Kind: defaultIdentityRefKind,
-							Name: "IdentitySecret",
+							Name: identitySecretName,
 						},
-						Zone:    "Zone",
-						Network: "Network",
+						Zone:    zone,
+						Network: network,
 						// Need CP Endpoint not to be nil before test or webhook will allow modification.
 						ControlPlaneEndpoint: clusterv1.APIEndpoint{Host: "fakeIP", Port: int32(1234)},
 					},
@@ -177,7 +192,7 @@ var _ = Describe("CloudStackCluster webhooks", func() {
 				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "identityRef\\.Kind"))
 
 				cloudStackCluster.DeepCopyInto(cloudStackClusterUpdate)
-				cloudStackClusterUpdate.Spec.IdentityRef.Name = "IdentityConfigMap"
+				cloudStackClusterUpdate.Spec.IdentityRef.Name = configMapName
 				Expect(k8sClient.Update(ctx, cloudStackClusterUpdate).Error()).Should(MatchRegexp(forbiddenRegex, "identityRef\\.Name"))
 			})