Webhooks seem working.

Author: Joshua Reed

api/v1beta1/cloudstackcluster_types.go

@@ -24,8 +24,8 @@ import (
 )
 
 const (
-	ClusterFinalizer           = "cloudstackcluster.infrastructure.cluster.x-k8s.io"
-	defaultIdentityRefKind     = "Secret"
+	ClusterFinalizer = "cloudstackcluster.infrastructure.cluster.x-k8s.io"
+	// defaultIdentityRefKind     = "Secret"
 	CloudStackClusterLabelName = "cloudstackcluster.infrastructure.cluster.x-k8s.io/name"
 	NetworkTypeIsolated        = "Isolated"
 	NetworkTypeShared          = "Shared"

api/v1beta1/cloudstackcluster_webhook.go

@@ -0,0 +1,46 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1_test
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	infrav1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta1"
+	"time"
+)
+
+var _ = Describe("CloudStackMachine types", func() {
+	var cloudStackMachine infrav1.CloudStackMachine
+
+	BeforeEach(func() { // Reset test vars to initial state.
+		cloudStackMachine = infrav1.CloudStackMachine{}
+	})
+
+	Context("When calculating time since state change", func() {
+		It("Return the correct value when the last state update time is known", func() {
+			delta := time.Duration(10 * time.Minute)
+			lastUpdated := time.Now().Add(-delta)
+			cloudStackMachine.Status.InstanceStateLastUpdated = metav1.NewTime(lastUpdated)
+			Ω(cloudStackMachine.Status.TimeSinceLastStateChange()).Should(BeNumerically("~", delta, time.Second))
+		})
+
+		It("Return a negative value when the last state update time is unknown", func() {
+			Ω(cloudStackMachine.Status.TimeSinceLastStateChange()).Should(BeNumerically("<", 0))
+		})
+	})
+})

api/v1beta1/cloudstackmachine_types_test.go

@@ -0,0 +1,46 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1_test
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	infrav1 "sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta1"
+	"time"
+)
+
+var _ = Describe("CloudStackMachine types", func() {
+	var cloudStackMachine infrav1.CloudStackMachine
+
+	BeforeEach(func() { // Reset test vars to initial state.
+		cloudStackMachine = infrav1.CloudStackMachine{}
+	})
+
+	Context("When calculating time since state change", func() {
+		It("Return the correct value when the last state update time is known", func() {
+			delta := time.Duration(10 * time.Minute)
+			lastUpdated := time.Now().Add(-delta)
+			cloudStackMachine.Status.InstanceStateLastUpdated = metav1.NewTime(lastUpdated)
+			Ω(cloudStackMachine.Status.TimeSinceLastStateChange()).Should(BeNumerically("~", delta, time.Second))
+		})
+
+		It("Return a negative value when the last state update time is unknown", func() {
+			Ω(cloudStackMachine.Status.TimeSinceLastStateChange()).Should(BeNumerically("<", 0))
+		})
+	})
+})