Incorrect name 'FailureDomainName' in CloudStackMachine resource #324
Description
/kind bug
What steps did you take and what happened:
The field FailureDomainName in the CloudStackMachine resource is incorrectly named which causes CAPI to fail to adopt the field into the Machine resource (which should be the primary source of truth). The field should be named FailureDomain (json: failureDomain)
The relevant bit of code in CAPI: https://github.com/kubernetes-sigs/cluster-api/blob/bd9abfce8f5a0dbc4786eeff9834768f39a74ca6/internal/controllers/machine/machine_controller_phases.go#L312
the relevant bits in CAPI documentation:
To support migration from failure domains that were previously specified through provider-specific resources, the Machine controller will support updating Machine.Spec.FailureDomain field if Spec.FailureDomain is present and defined on the provider-defined infrastructure resource.
Fixing this is going to be a breaking API change, although i wonder whether anyone is actually using this, since it has been broken from the start.
What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
- Cluster-api-provider-cloudstack version:
- Kubernetes version: (use
kubectl version): - OS (e.g. from
/etc/os-release):