Skip to content

Commit 02380f5

Browse files
meobilivangrichardcase
authored andcommitted
instrument cloud/scope
1 parent af8aab2 commit 02380f5

File tree

5 files changed

+49
-0
lines changed

5 files changed

+49
-0
lines changed

cloud/scope/clients.go

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import (
3232
"k8s.io/client-go/pkg/version"
3333
"k8s.io/client-go/util/flowcontrol"
3434
infrav1 "sigs.k8s.io/cluster-api-provider-gcp/api/v1beta1"
35+
"sigs.k8s.io/cluster-api-provider-gcp/util/telemetry"
3536
"sigs.k8s.io/controller-runtime/pkg/client"
3637
)
3738

@@ -90,6 +91,11 @@ func defaultClientOptions(ctx context.Context, credentialsRef *infrav1.ObjectRef
9091
}
9192

9293
func newComputeService(ctx context.Context, credentialsRef *infrav1.ObjectReference, crClient client.Client, endpoints *infrav1.ServiceEndpoints) (*compute.Service, error) {
94+
ctx, span := telemetry.Tracer().Start(
95+
ctx, "cloud.clients.newComputeService",
96+
)
97+
defer span.End()
98+
9399
opts, err := defaultClientOptions(ctx, credentialsRef, crClient)
94100
if err != nil {
95101
return nil, fmt.Errorf("getting default gcp client options: %w", err)
@@ -108,6 +114,11 @@ func newComputeService(ctx context.Context, credentialsRef *infrav1.ObjectRefere
108114
}
109115

110116
func newClusterManagerClient(ctx context.Context, credentialsRef *infrav1.ObjectReference, crClient client.Client, endpoints *infrav1.ServiceEndpoints) (*container.ClusterManagerClient, error) {
117+
ctx, span := telemetry.Tracer().Start(
118+
ctx, "cloud.clients.newClusterManagerClient",
119+
)
120+
defer span.End()
121+
111122
opts, err := defaultClientOptions(ctx, credentialsRef, crClient)
112123
if err != nil {
113124
return nil, fmt.Errorf("getting default gcp client options: %w", err)
@@ -126,6 +137,11 @@ func newClusterManagerClient(ctx context.Context, credentialsRef *infrav1.Object
126137
}
127138

128139
func newIamCredentialsClient(ctx context.Context, credentialsRef *infrav1.ObjectReference, crClient client.Client, endpoints *infrav1.ServiceEndpoints) (*credentials.IamCredentialsClient, error) {
140+
ctx, span := telemetry.Tracer().Start(
141+
ctx, "cloud.clients.newIamCredentialsClient",
142+
)
143+
defer span.End()
144+
129145
opts, err := defaultClientOptions(ctx, credentialsRef, crClient)
130146
if err != nil {
131147
return nil, fmt.Errorf("getting default gcp client options: %w", err)
@@ -144,6 +160,11 @@ func newIamCredentialsClient(ctx context.Context, credentialsRef *infrav1.Object
144160
}
145161

146162
func newInstanceGroupManagerClient(ctx context.Context, credentialsRef *infrav1.ObjectReference, crClient client.Client, endpoints *infrav1.ServiceEndpoints) (*computerest.InstanceGroupManagersClient, error) {
163+
ctx, span := telemetry.Tracer().Start(
164+
ctx, "cloud.clients.newInstanceGroupManagerClient",
165+
)
166+
defer span.End()
167+
147168
opts, err := defaultClientOptions(ctx, credentialsRef, crClient)
148169
if err != nil {
149170
return nil, fmt.Errorf("getting default gcp client options: %w", err)

cloud/scope/cluster.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"k8s.io/utils/ptr"
2828
infrav1 "sigs.k8s.io/cluster-api-provider-gcp/api/v1beta1"
2929
"sigs.k8s.io/cluster-api-provider-gcp/cloud"
30+
"sigs.k8s.io/cluster-api-provider-gcp/util/telemetry"
3031
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
3132
"sigs.k8s.io/cluster-api/util/patch"
3233
"sigs.k8s.io/controller-runtime/pkg/client"
@@ -43,6 +44,12 @@ type ClusterScopeParams struct {
4344
// NewClusterScope creates a new Scope from the supplied parameters.
4445
// This is meant to be called for each reconcile iteration.
4546
func NewClusterScope(ctx context.Context, params ClusterScopeParams) (*ClusterScope, error) {
47+
48+
ctx, span := telemetry.Tracer().Start(
49+
ctx, "cloud.clusterScope.NewClusterScope",
50+
)
51+
defer span.End()
52+
4653
if params.Cluster == nil {
4754
return nil, errors.New("failed to generate new scope from nil Cluster")
4855
}

cloud/scope/managedcluster.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
infrav1 "sigs.k8s.io/cluster-api-provider-gcp/api/v1beta1"
2828
"sigs.k8s.io/cluster-api-provider-gcp/cloud"
2929
infrav1exp "sigs.k8s.io/cluster-api-provider-gcp/exp/api/v1beta1"
30+
"sigs.k8s.io/cluster-api-provider-gcp/util/telemetry"
3031
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
3132
"sigs.k8s.io/cluster-api/util/patch"
3233
"sigs.k8s.io/controller-runtime/pkg/client"
@@ -44,6 +45,12 @@ type ManagedClusterScopeParams struct {
4445
// NewManagedClusterScope creates a new Scope from the supplied parameters.
4546
// This is meant to be called for each reconcile iteration.
4647
func NewManagedClusterScope(ctx context.Context, params ManagedClusterScopeParams) (*ManagedClusterScope, error) {
48+
49+
ctx, span := telemetry.Tracer().Start(
50+
ctx, "cloud.managedClusterScope.NewManagedClusterScope",
51+
)
52+
defer span.End()
53+
4754
if params.Cluster == nil {
4855
return nil, errors.New("failed to generate new scope from nil Cluster")
4956
}

cloud/scope/managedcontrolplane.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"fmt"
2222

2323
"sigs.k8s.io/cluster-api-provider-gcp/util/location"
24+
"sigs.k8s.io/cluster-api-provider-gcp/util/telemetry"
2425

2526
"sigs.k8s.io/cluster-api/util/conditions"
2627

@@ -54,6 +55,12 @@ type ManagedControlPlaneScopeParams struct {
5455
// NewManagedControlPlaneScope creates a new Scope from the supplied parameters.
5556
// This is meant to be called for each reconcile iteration.
5657
func NewManagedControlPlaneScope(ctx context.Context, params ManagedControlPlaneScopeParams) (*ManagedControlPlaneScope, error) {
58+
59+
ctx, span := telemetry.Tracer().Start(
60+
ctx, "cloud.managedControlPlaneScope.NewManagedControlPlaneScope",
61+
)
62+
defer span.End()
63+
5764
if params.Cluster == nil {
5865
return nil, errors.New("failed to generate new scope from nil Cluster")
5966
}

cloud/scope/managedmachinepool.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
infrav1 "sigs.k8s.io/cluster-api-provider-gcp/api/v1beta1"
2626
"sigs.k8s.io/cluster-api-provider-gcp/cloud"
2727
"sigs.k8s.io/cluster-api-provider-gcp/util/location"
28+
"sigs.k8s.io/cluster-api-provider-gcp/util/telemetry"
2829

2930
"sigs.k8s.io/cluster-api/util/conditions"
3031

@@ -54,6 +55,12 @@ type ManagedMachinePoolScopeParams struct {
5455
// NewManagedMachinePoolScope creates a new Scope from the supplied parameters.
5556
// This is meant to be called for each reconcile iteration.
5657
func NewManagedMachinePoolScope(ctx context.Context, params ManagedMachinePoolScopeParams) (*ManagedMachinePoolScope, error) {
58+
59+
ctx, span := telemetry.Tracer().Start(
60+
ctx, "cloud.managedMachinePoolScope.NewManagedMachinePoolScope",
61+
)
62+
defer span.End()
63+
5764
if params.Cluster == nil {
5865
return nil, errors.New("failed to generate new scope from nil Cluster")
5966
}

0 commit comments

Comments
 (0)