fix linting

Author: damdo

.github/workflows/lint.yml

@@ -23,4 +23,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
         with:
-          version: v1.58
+          version: v1.61

.golangci.yml

@@ -14,7 +14,7 @@ linters:
     - errcheck
     - errchkjson
     - errname
-    - exportloopref
+    - copyloopvar
     - fatcontext
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -148,6 +148,12 @@ issues:
     - linters:
         - gosec
       text: "G108: Profiling endpoint is automatically exposed on /debug/pprof"
+    - linters:
+        - gosec
+      text: "G115: integer overflow conversion int -> int32"
+    - linters:
+        - govet
+      text: "printf: non-constant format string in call to sigs.k8s.io/cluster-api/util/conditions.MarkFalse"
     - linters:
         - revive
       text: "exported: exported method .*\\.(Reconcile|SetupWithManager|SetupWebhookWithManager) should have comment or be unexported"

api/v1beta1/gcpcluster_webhook_test.go

@@ -87,7 +87,6 @@ func TestGCPCluster_ValidateUpdate(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 			warn, err := test.newCluster.ValidateUpdate(test.oldCluster)

api/v1beta1/gcpclustertemplate_webhook_test.go

@@ -81,7 +81,6 @@ func TestGCPClusterTemplate_ValidateUpdate(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 			warn, err := test.newTemplate.ValidateUpdate(test.oldTemplate)

api/v1beta1/gcpmachine_webhook_test.go

@@ -167,7 +167,6 @@ func TestGCPMachine_ValidateCreate(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 			warn, err := test.GCPMachine.ValidateCreate()

api/v1beta1/gcpmachinetemplate_webhook_test.go

@@ -107,7 +107,6 @@ func TestGCPMachineTemplate_ValidateCreate(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 			warn, err := test.template.ValidateCreate()

cloud/scope/managedcontrolplane.go

@@ -180,7 +180,7 @@ func (s *ManagedControlPlaneScope) GetCredential() *Credential {
 
 // GetAllNodePools gets all node pools for the control plane.
 func (s *ManagedControlPlaneScope) GetAllNodePools(ctx context.Context) ([]infrav1exp.GCPManagedMachinePool, []clusterv1exp.MachinePool, error) {
-	if s.AllManagedMachinePools == nil || len(s.AllManagedMachinePools) == 0 {
+	if len(s.AllManagedMachinePools) == 0 {
 		listOptions := []client.ListOption{
 			client.InNamespace(s.GCPManagedControlPlane.Namespace),
 			client.MatchingLabels(map[string]string{clusterv1.ClusterNameLabel: s.Cluster.Name}),

cloud/scope/managedmachinepool.go

@@ -237,7 +237,7 @@ func ConvertToSdkNodePool(nodePool infrav1exp.GCPManagedMachinePool, machinePool
 		sdkNodePool.Config.DiskType = string(*nodePool.Spec.DiskType)
 	}
 	if nodePool.Spec.DiskSizeGB != nil {
-		sdkNodePool.Config.DiskSizeGb = int32(*nodePool.Spec.DiskSizeGB)
+		sdkNodePool.Config.DiskSizeGb = int32(*nodePool.Spec.DiskSizeGB) //nolint:gosec
 	}
 	if len(nodePool.Spec.NodeNetwork.Tags) != 0 {
 		sdkNodePool.Config.Tags = nodePool.Spec.NodeNetwork.Tags

controllers/suite_test.go

@@ -50,9 +50,8 @@ func init() {
 func TestAPIs(t *testing.T) {
 	RegisterFailHandler(Fail)
 	// fetch the current config
-	suiteConfig, reporterConfig := GinkgoConfiguration()
+	_, reporterConfig := GinkgoConfiguration()
 	// adjust it
-	suiteConfig.FailFast = true
 	reporterConfig.FullTrace = true
 	RunSpecs(t, "Controller Suite", reporterConfig)
 }

exp/api/v1beta1/gcpmanagedmachinepool_webhook.go

@@ -89,31 +89,31 @@ func (r *GCPManagedMachinePool) validateScaling() field.ErrorList {
 		maxField := field.NewPath("spec", "scaling", "maxCount")
 		locationPolicyField := field.NewPath("spec", "scaling", "locationPolicy")
 
-		min := r.Spec.Scaling.MinCount
-		max := r.Spec.Scaling.MaxCount
+		minCount := r.Spec.Scaling.MinCount
+		maxCount := r.Spec.Scaling.MaxCount
 		locationPolicy := r.Spec.Scaling.LocationPolicy
 
 		// cannot specify autoscaling config if autoscaling is disabled
 		if r.Spec.Scaling.EnableAutoscaling != nil && !*r.Spec.Scaling.EnableAutoscaling {
-			if min != nil {
+			if minCount != nil {
 				allErrs = append(allErrs, field.Forbidden(minField, "minCount cannot be specified when autoscaling is disabled"))
 			}
-			if max != nil {
+			if maxCount != nil {
 				allErrs = append(allErrs, field.Forbidden(maxField, "maxCount cannot be specified when autoscaling is disabled"))
 			}
 			if locationPolicy != nil {
 				allErrs = append(allErrs, field.Forbidden(locationPolicyField, "locationPolicy cannot be specified when autoscaling is disabled"))
 			}
 		}
 
-		if min != nil {
+		if minCount != nil {
 			// validates min >= 0
-			if *min < 0 {
-				allErrs = append(allErrs, field.Invalid(minField, *min, "must be greater or equal zero"))
+			if *minCount < 0 {
+				allErrs = append(allErrs, field.Invalid(minField, *minCount, "must be greater or equal zero"))
 			}
 			// validates min <= max
-			if max != nil && *max < *min {
-				allErrs = append(allErrs, field.Invalid(maxField, *max, "must be greater than field "+minField.String()))
+			if maxCount != nil && *maxCount < *minCount {
+				allErrs = append(allErrs, field.Invalid(maxField, *maxCount, "must be greater than field "+minField.String()))
 			}
 		}
 	}